[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/9] qcow2: use external virtual timers
From: |
Max Reitz |
Subject: |
[PULL 4/9] qcow2: use external virtual timers |
Date: |
Tue, 30 Mar 2021 14:39:52 +0200 |
From: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>
Regular virtual timers are used to emulate timings
related to vCPU and peripheral states. QCOW2 uses timers
to clean the cache. These timers should have external
flag. In the opposite case they affect the execution
and it can't be recorded and replayed.
This patch adds external flag to the timer for qcow2
cache clean.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <161700516327.1141158.8366564693714562536.stgit@pasha-ThinkPad-X280>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
block/qcow2.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 0db1227ac9..2fb43c6f7e 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -840,9 +840,10 @@ static void cache_clean_timer_init(BlockDriverState *bs,
AioContext *context)
{
BDRVQcow2State *s = bs->opaque;
if (s->cache_clean_interval > 0) {
- s->cache_clean_timer = aio_timer_new(context, QEMU_CLOCK_VIRTUAL,
- SCALE_MS, cache_clean_timer_cb,
- bs);
+ s->cache_clean_timer =
+ aio_timer_new_with_attrs(context, QEMU_CLOCK_VIRTUAL,
+ SCALE_MS, QEMU_TIMER_ATTR_EXTERNAL,
+ cache_clean_timer_cb, bs);
timer_mod(s->cache_clean_timer, qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL) +
(int64_t) s->cache_clean_interval * 1000);
}
--
2.29.2
- [PULL 0/9] Block patches for 6.0-rc1, Max Reitz, 2021/03/30
- [PULL 1/9] iotests: Fix typo in iotest 051, Max Reitz, 2021/03/30
- [PULL 2/9] iotests: fix 051.out expected output after error text touchups, Max Reitz, 2021/03/30
- [PULL 3/9] iotests/116: Fix reference output, Max Reitz, 2021/03/30
- [PULL 4/9] qcow2: use external virtual timers,
Max Reitz <=
- [PULL 5/9] iotests/046: Filter request length, Max Reitz, 2021/03/30
- [PULL 8/9] qcow2: Force preallocation with data-file-raw, Max Reitz, 2021/03/30
- [PULL 9/9] iotests/244: Test preallocation for data-file-raw, Max Reitz, 2021/03/30
- [PULL 6/9] block/mirror: Fix mirror_top's permissions, Max Reitz, 2021/03/30
- [PULL 7/9] qsd: Document FUSE exports, Max Reitz, 2021/03/30
- Re: [PULL 0/9] Block patches for 6.0-rc1, Peter Maydell, 2021/03/30