|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v2] replay: notify CPU on event |
Date: | Mon, 29 Mar 2021 14:10:40 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 29/03/21 13:23, Pavel Dovgalyuk wrote:
I still do not understand why the qemu_clock_notify function is used to notify the CPU. It would be nice to have a description of the call chain in a comment or to have a more appropriate API. I can queue the patch since it's deep in replay-events.c and not in common code, but if you post a short description here I'll integrate it.Maybe I missed something. This call is needed for the case when vCPU is waiting in rr_wait_io_event. You mean that we can use qemu_cpu_kick instead?
I have no idea. Using qemu_clock_notify however is definitely weird. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |