Re: [RFC v12 46/65] target/arm: create kvm cpu accel class

[Richard Henderson]

On 3/26/21 1:36 PM, Claudio Fontana wrote:
> move init, realizefn and reset code into it.
>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
>   target/arm/internals.h     |   1 -
>   target/arm/cpu-sysemu.c    |  32 ----------
>   target/arm/cpu.c           |  48 ++------------
>   target/arm/kvm/kvm-cpu.c   | 128 +++++++++++++++++++++++++++++++++++++
>   target/arm/kvm/meson.build |   1 +
>   5 files changed, 136 insertions(+), 74 deletions(-)
>   create mode 100644 target/arm/kvm/kvm-cpu.c

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> +static void host_cpu_instance_init(Object *obj)
> +{
> +    ARMCPU *cpu = ARM_CPU(obj);
> +
> +    kvm_arm_set_cpu_features_from_host(cpu);
> +    if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64)) {
> +        aarch64_add_sve_properties(obj);
> +    }
> +    arm_cpu_post_init(obj);
> +}

Note for another patch: ARM_FEATURE_AARCH64 is always true for kvm, because 
we've already deprecated and removed 32-bit kvm.  This is a fossil check.


r~