Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member

From:	John Snow
Subject:	Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member
Date:	Thu, 25 Mar 2021 17:04:18 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 3/25/21 10:26 AM, Markus Armbruster wrote:

Suggest

     qapi/expr.py: Check type of union and alternate 'data' member

John Snow <jsnow@redhat.com> writes:

We don't actually check, so the user can get some unpleasant stacktraces.


Let's point to the new tests here.

Well, it'll get merged with the last one to keep make check working, soI have to update the commit message anyway.

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v4 04/19] qapi/expr.py: Check for dict instead of OrderedDict, (continued)
- [PATCH v4 04/19] qapi/expr.py: Check for dict instead of OrderedDict, John Snow, 2021/03/25
- [PATCH v4 07/19] qapi/expr.py: move string check upwards in check_type, John Snow, 2021/03/25
- [PATCH v4 05/19] qapi/expr.py: constrain incoming expression types, John Snow, 2021/03/25
  - Re: [PATCH v4 05/19] qapi/expr.py: constrain incoming expression types, Markus Armbruster, 2021/03/25
    - Re: [PATCH v4 05/19] qapi/expr.py: constrain incoming expression types, John Snow, 2021/03/25
- [PATCH v4 06/19] qapi/expr.py: Add assertion for union type 'check_dict', John Snow, 2021/03/25
- [PATCH v4 08/19] qapi: add tests for invalid 'data' field type, John Snow, 2021/03/25
  - Re: [PATCH v4 08/19] qapi: add tests for invalid 'data' field type, Markus Armbruster, 2021/03/25
- [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member, John Snow, 2021/03/25
  - Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member, Markus Armbruster, 2021/03/25
    - Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member, John Snow <=
- [PATCH v4 10/19] qapi/expr.py: Add casts in a few select cases, John Snow, 2021/03/25
  - Re: [PATCH v4 10/19] qapi/expr.py: Add casts in a few select cases, Markus Armbruster, 2021/03/25
    - Re: [PATCH v4 10/19] qapi/expr.py: Add casts in a few select cases, John Snow, 2021/03/25
- [PATCH v4 12/19] qapi/expr.py: add type hint annotations, John Snow, 2021/03/25
- [PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if, John Snow, 2021/03/25
  - Re: [PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if, Markus Armbruster, 2021/03/25
    - Re: [PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if, John Snow, 2021/03/25
- [PATCH v4 15/19] qapi/expr.py: enable pylint checks, John Snow, 2021/03/25
- [PATCH v4 17/19] qapi/expr.py: Use tuples instead of lists for static data, John Snow, 2021/03/25
  - Re: [PATCH v4 17/19] qapi/expr.py: Use tuples instead of lists for static data, Markus Armbruster, 2021/03/25

Prev by Date: Re: [RFC 0/8] virtio: Improve boot time of virtio-scsi-pci and virtio-blk-pci
Next by Date: Re: [RFC v11 22/55] target/arm: move sve_zcr_len_for_el to common_cpu
Previous by thread: Re: [PATCH v4 09/19] qapi/expr.py: Check type of 'data' member
Next by thread: [PATCH v4 10/19] qapi/expr.py: Add casts in a few select cases
Index(es):
- Date
- Thread