[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v11 28/55] target/arm: refactor exception and cpu code
From: |
Claudio Fontana |
Subject: |
Re: [RFC v11 28/55] target/arm: refactor exception and cpu code |
Date: |
Thu, 25 Mar 2021 19:50:55 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 3/25/21 7:43 PM, Richard Henderson wrote:
> On 3/25/21 5:59 AM, Claudio Fontana wrote:
>>> Isn't tcg/tcg-* redundant?
>>
>> I considered that, and at some point I had "cpu.c" for x86 too. After
>> working on it for a while, I noticed how
>> it got really confusing in practice to have files called just "cpu.c" when
>> working on them, just too many files are called "cpu.c". It was confusing.
>>
>> I also like the extra emphasis on the accel for this:
>>
>> kvm/kvm.c
>> kvm/kvm-cpu.c
>> kvm/kvm-stub.c
>>
>> tcg/tcg-cpu.c
>> tcg/tcg-stub.c
>
> But then you go and invent
>
> cpu-sve.c
> kvm/cpu-sve.c
> tcg/cpu-sve.c
>
> etc. So, please make up your mind.
>
Inconsistencies are all over already, and the two are very unrelated things.
tcg-cpu comes from accel-cpu, where accel- is replaced by tcg- in this case.
cpu-sve is a specialization of "cpu" where we currently put all the properties
and the like.
cpu-sve-props is probably a better name.
- [RFC v11 42/55] target/arm: move kvm post init initialization to kvm cpu accel, (continued)
- [RFC v11 42/55] target/arm: move kvm post init initialization to kvm cpu accel, Claudio Fontana, 2021/03/23
- [RFC v11 41/55] target/arm: create kvm cpu accel class, Claudio Fontana, 2021/03/23
- [RFC v11 36/55] tests: restrict TCG-only arm-cpu-features tests to TCG builds, Claudio Fontana, 2021/03/23
- [RFC v11 37/55] tests: do not run test-hmp on all machines for ARM KVM-only, Claudio Fontana, 2021/03/23
- [RFC v11 38/55] tests: device-introspect-test: cope with ARM TCG-only devices, Claudio Fontana, 2021/03/23
- [RFC v11 44/55] target/arm: move TCG gt timer creation code in tcg/, Claudio Fontana, 2021/03/23
- [RFC v11 28/55] target/arm: refactor exception and cpu code, Claudio Fontana, 2021/03/23
[RFC v11 51/55] target/arm: cpu-pauth: new module for ARMv8.3 Pointer Authentication, Claudio Fontana, 2021/03/23
[RFC v11 34/55] target/arm: remove broad "else" statements when checking accels, Claudio Fontana, 2021/03/23
[RFC v11 53/55] XXX target/arm: experiment refactoring cpu "max", Claudio Fontana, 2021/03/23
[RFC v11 50/55] target/arm: tcg: restrict ZCR cpregs to TARGET_AARCH64, Claudio Fontana, 2021/03/23
[RFC v11 46/55] target/arm: cpu-sve: split TCG and KVM functionality, Claudio Fontana, 2021/03/23
[RFC v11 43/55] target/arm: add tcg cpu accel class, Claudio Fontana, 2021/03/23
[RFC v11 48/55] target/arm: arch_dump: restrict ELFCLASS64 to AArch64, Claudio Fontana, 2021/03/23