Re: [RFC PATCH v2 0/3] virtio-net: graceful drop of vhost for TAP

[Jason Wang]

在 2021/3/22 下午8:24, Yuri Benditovich 写道:
> Allow fallback to userspace only upon migration, only for specific features
> and only if 'vhostforce' is not requested.
>
> Changes from v1:
> Patch 1 dropeed (will be submitted in another series)
> Added device callback in case the migration should fail due to missing features


Hi Yuri:

Have a quick glance at the series. A questions is why we need to do the 
fallback only during load?

I think we should do it in the device initializating. E.g when the vhost 
features can not satisfy, we should disable vhost since there.

Thanks


> Yuri Benditovich (3):
>    net: add ability to hide (disable) vhost_net
>    virtio: introduce 'missing_features_migrated' device callback
>    virtio-net: implement missing_features_migrated callback
>
>   hw/net/vhost_net.c         |  4 ++-
>   hw/net/virtio-net.c        | 51 ++++++++++++++++++++++++++++++++++++++
>   hw/virtio/virtio.c         |  8 ++++++
>   include/hw/virtio/virtio.h |  8 ++++++
>   include/net/net.h          |  1 +
>   5 files changed, 71 insertions(+), 1 deletion(-)