[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/2] migrate-bitmaps-postcopy-test: check that we can't remove in-
From: |
Stefan Hajnoczi |
Subject: |
[PULL 2/2] migrate-bitmaps-postcopy-test: check that we can't remove in-flight bitmaps |
Date: |
Wed, 24 Mar 2021 14:52:02 +0000 |
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Check that we can't remove bitmaps being migrated on destination vm.
The new check proves that previous commit helps.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20210322094906.5079-3-vsementsov@virtuozzo.com>
---
tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
index d046ebeb94..584062b412 100755
--- a/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
+++ b/tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test
@@ -224,6 +224,16 @@ class
TestDirtyBitmapPostcopyMigration(iotests.QMPTestCase):
self.start_postcopy()
self.vm_b_events += self.vm_b.get_qmp_events()
+
+ # While being here, let's check that we can't remove in-flight bitmaps.
+ for vm in (self.vm_a, self.vm_b):
+ for i in range(0, nb_bitmaps):
+ result = vm.qmp('block-dirty-bitmap-remove', node='drive0',
+ name=f'bitmap{i}')
+ self.assert_qmp(result, 'error/desc',
+ f"Bitmap 'bitmap{i}' is currently in use by "
+ "another operation and cannot be used")
+
self.vm_b.shutdown()
# recreate vm_b, so there is no incoming option, which prevents
# loading bitmaps from disk
--
2.30.2
- [PULL 0/2] Block patches, Stefan Hajnoczi, 2021/03/24
- [PULL 1/2] migration/block-dirty-bitmap: make incoming disabled bitmaps busy, Stefan Hajnoczi, 2021/03/24
- [PULL 2/2] migrate-bitmaps-postcopy-test: check that we can't remove in-flight bitmaps,
Stefan Hajnoczi <=
- Re: [PULL 0/2] Block patches, Peter Maydell, 2021/03/24
- Re: [PULL 0/2] Block patches, Vladimir Sementsov-Ogievskiy, 2021/03/24
- Re: [PULL 0/2] Block patches, Peter Maydell, 2021/03/24
- Re: [PULL 0/2] Block patches, Stefan Hajnoczi, 2021/03/25
- Re: [PULL 0/2] Block patches, Vladimir Sementsov-Ogievskiy, 2021/03/25
- Re: [PULL 0/2] Block patches, Stefan Hajnoczi, 2021/03/25
- Re: [PULL 0/2] Block patches, Peter Maydell, 2021/03/25
- Re: [PULL 0/2] Block patches, Stefan Hajnoczi, 2021/03/25
Re: [PULL 0/2] Block patches, Peter Maydell, 2021/03/26