[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] yank: Always link full yank code
From: |
Lukas Straub |
Subject: |
Re: [PATCH 0/2] yank: Always link full yank code |
Date: |
Wed, 24 Mar 2021 12:22:42 +0100 |
On Tue, 23 Mar 2021 19:09:15 +0000
Daniel P. Berrangé <berrange@redhat.com> wrote:
> On Tue, Mar 23, 2021 at 06:52:19PM +0100, Lukas Straub wrote:
> > Hello Everyone,
> > These patches remove yank's dependency on qiochannel and always link it in.
> > Please Review.
>
> It would be useful if the cover letter or commit messages explained
> to potential reviewers why this is being changed... The first patch
> feels like a regression to me, without seeing an explanation why
> it is desirable.
Yes, sorry. There are two reasons for this patchset:
-To exercise the full yank code (with checks for registering and unregistering
of yank functions and instances) in existing tests and in the new yank test
(cover.1616521487.git.lukasstraub2@web.de/">https://lore.kernel.org/qemu-devel/cover.1616521487.git.lukasstraub2@web.de/)
-To replace "[PATCH] yank: Avoid linking into executables that don't want it"
(20210316135907.3646901-1-armbru@redhat.com/">https://lore.kernel.org/qemu-devel/20210316135907.3646901-1-armbru@redhat.com/)
Now we always link in yank, but without pulling in other dependencies.
Regards,
Lukas Straub
>
> Regards,
> Daniel
--
pgpfoVE6BSXwN.pgp
Description: OpenPGP digital signature