On Mon, Mar 22, 2021 at 11:27:17AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > > + if (vd->msgsize != msg->size + sizeof(*msg)) {
> > > + /* FIXME: handle parse messages splitted into multiple chunks */
> > > + fprintf(stderr, "%s: size mismatch: chunk %d, msg %d (+%zd)\n",
> > > + __func__, vd->msgsize, msg->size, sizeof(*msg));
> > >
> >
> > Not fixing? You handle chunking on sending but not on receiving?
>
> linux vdagent doesn't do chunking on send, so no need (and also no
> testcase) so far.
>
> Didn't try windows guests (yet), but that is next on my clipboard
> todo list.
Hmm, windows guest agent doesn't has VD_AGENT_CAP_CLIPBOARD_SELECTION,
so I have to deal with that.
ok
Windows guests do actually send large messages in chunks, so I have
something to test with, good.
What are VD_AGENT_CAP_GUEST_LINEEND_LF + VD_AGENT_CAP_GUEST_LINEEND_CRLF
are good for btw? Are linefeeds converted automatically between dos and
unix conventions? If so, who is supposed to handle that?
I think that means the guest agent uses a text clipboard with CRLF ending, both ways. spice-gtk has dos2unix & unix2dos helpers to deal with that.
--
Marc-André Lureau