Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread

[Andrey Gruzdev]

On 23.03.2021 21:35, Peter Xu wrote:

> On Tue, Mar 23, 2021 at 08:21:43PM +0300, Andrey Gruzdev wrote:
> > > For the long term I think we'd better have a helper:
> > >
> > >          qemu_put_qio_channel_buffer(QEMUFile *file, QIOChannelBuffer *bioc)
> > >
> > > So as to hide this flush operation, which is tricky. We'll have two users so
> > > far:
> > >
> > >          bg_migration_completion
> > >          colo_do_checkpoint_transaction
> > >
> > > IMHO it'll be nicer if you'd do it in this patch altogether!
> > >
> > > Thanks,
> > >
> > >         
> > Sorry, can't get the idea, what's wrong with the fix.
> >       
> I'm fine with the fix, but I've got one patch attached just to show what I
> meant, so without any testing for sure..
>
> Looks more complicated than I thought, but again I think we should hide that
> buffer flush into another helper to avoid overlooking it.
>     
Thanks, Peter, now I've got what you meant - not to overlook flush on buffer channel.
But it seems that adding a reasonable comment is enough here.
> Thanks,
>
>