Re: [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend

[no-reply]

Patchew URL: 
cover.1616570702.git.viresh.kumar@linaro.org/">https://patchew.org/QEMU/cover.1616570702.git.viresh.kumar@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: cover.1616570702.git.viresh.kumar@linaro.org
Subject: [PATCH 0/5] virtio: Implement generic vhost-user-i2c backend

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/cover.1616570702.git.viresh.kumar@linaro.org -> 
patchew/cover.1616570702.git.viresh.kumar@linaro.org
Switched to a new branch 'test'
40ccc27 MAINTAINERS: Add entry for virtio-i2c
9b632f4 docs: add a man page for vhost-user-i2c
5da2cca tools/vhost-user-i2c: Add backend driver
6716f9a hw/virtio: add vhost-user-i2c-pci boilerplate
d6439eb hw/virtio: add boilerplate for vhost-user-i2c device

=== OUTPUT BEGIN ===
1/5 Checking commit d6439ebcaa1d (hw/virtio: add boilerplate for vhost-user-i2c 
device)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#46: 
new file mode 100644

total: 0 errors, 1 warnings, 344 lines checked

Patch 1/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/5 Checking commit 6716f9a6b4c1 (hw/virtio: add vhost-user-i2c-pci boilerplate)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

total: 0 errors, 1 warnings, 86 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/5 Checking commit 5da2ccae459c (tools/vhost-user-i2c: Add backend driver)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#52: 
new file mode 100644

ERROR: spaces required around that '*' (ctx:WxV)
#137: FILE: tools/vhost-user-i2c/main.c:70:
+        const typeof(((type *) 0)->member) *__mptr = (ptr);     \
                                            ^

ERROR: space required after that ';' (ctx:VxV)
#138: FILE: tools/vhost-user-i2c/main.c:71:
+        (type *) ((char *) __mptr - offsetof(type, member));})
                                                            ^

ERROR: line over 90 characters
#163: FILE: tools/vhost-user-i2c/main.c:96:
+    { "socket-path", 's', 0, G_OPTION_ARG_FILENAME, &socket_path, "Location of 
vhost-user Unix domain socket, incompatible with --fd", "PATH" },

ERROR: line over 90 characters
#164: FILE: tools/vhost-user-i2c/main.c:97:
+    { "fd", 'f', 0, G_OPTION_ARG_INT, &socket_fd, "Specify the file-descriptor 
of the backend, incompatible with --socket-path", "FD" },

ERROR: line over 90 characters
#165: FILE: tools/vhost-user-i2c/main.c:98:
+    { "device-list", 'l', 0, G_OPTION_ARG_STRING, &device_list, "List of 
i2c-dev bus and attached devices", "I2C Devices" },

ERROR: line over 90 characters
#166: FILE: tools/vhost-user-i2c/main.c:99:
+    { "print-capabilities", 'c', 0, G_OPTION_ARG_NONE, &print_cap, "Output to 
stdout the backend capabilities in JSON format and exit", NULL},

WARNING: line over 80 characters
#167: FILE: tools/vhost-user-i2c/main.c:100:
+    { "verbose", 'v', 0, G_OPTION_ARG_NONE, &verbose, "Be more verbose in 
output", NULL},

WARNING: line over 80 characters
#209: FILE: tools/vhost-user-i2c/main.c:142:
+     * Adapter        | adapter2 | none  | adapter1 | adapter3 | none | none| 
(val)

WARNING: line over 80 characters
#211: FILE: tools/vhost-user-i2c/main.c:144:
+     * Slave Address  | addr 1   | none  | addr 2   | addr 3   | none | none| 
(idx)

ERROR: do not use assignment in if condition
#241: FILE: tools/vhost-user-i2c/main.c:174:
+    if (addr < MAX_I2C_VDEV && ((idx = i2c->adapter_map[addr]) != 0)) {

ERROR: braces {} are necessary for all arms of this statement
#288: FILE: tools/vhost-user-i2c/main.c:221:
+    if (bus < 0)
[...]

WARNING: line over 80 characters
#316: FILE: tools/vhost-user-i2c/main.c:249:
+                g_printerr("client addr 0x%x repeat, not allowed.\n", 
client_addr[i]);

ERROR: code indent should never use tabs
#340: FILE: tools/vhost-user-i2c/main.c:273:
+ * ^Ie.g. 2 for /dev/i2c-2$

ERROR: code indent should never use tabs
#342: FILE: tools/vhost-user-i2c/main.c:275:
+ * ^Ie.g. 0x1C or 1C$

ERROR: spaces required around that '==' (ctx:WxV)
#359: FILE: tools/vhost-user-i2c/main.c:292:
+        if (!cp || *cp =='\0') {
                        ^

ERROR: unnecessary whitespace before a quoted newline
#364: FILE: tools/vhost-user-i2c/main.c:297:
+            g_printerr("too many adapter (%d), only support %d \n", n_adapter,

ERROR: spaces required around that '!=' (ctx:WxV)
#378: FILE: tools/vhost-user-i2c/main.c:311:
+        while (cp != NULL && *cp !='\0') {
                                  ^

ERROR: braces {} are necessary for all arms of this statement
#379: FILE: tools/vhost-user-i2c/main.c:312:
+            if (*cp == ':')
[...]

ERROR: unnecessary whitespace before a quoted newline
#383: FILE: tools/vhost-user-i2c/main.c:316:
+                g_printerr("too many devices (%d), only support %d \n",

WARNING: line over 80 characters
#388: FILE: tools/vhost-user-i2c/main.c:321:
+            if (qemu_strtol(cp, &t, 16, &addr) || addr < 0 || addr > 
MAX_I2C_VDEV) {

WARNING: line over 80 characters
#400: FILE: tools/vhost-user-i2c/main.c:333:
+        i2c->adapter[n_adapter] = vi2c_create_adapter(bus, client_addr, 
n_client);

ERROR: braces {} are necessary for all arms of this statement
#401: FILE: tools/vhost-user-i2c/main.c:334:
+        if (!i2c->adapter[n_adapter])
[...]

WARNING: line over 80 characters
#438: FILE: tools/vhost-user-i2c/main.c:371:
+        g_printerr("Failed to transfer data to address %x : %d\n", msg->addr, 
errno);

ERROR: that open brace { should be on the previous line
#632: FILE: tools/vhost-user-i2c/main.c:565:
+    if (!g_option_context_parse(context, &argc, &argv, &error))
+    {

WARNING: line over 80 characters
#653: FILE: tools/vhost-user-i2c/main.c:586:
+                          G_LOG_LEVEL_WARNING | G_LOG_LEVEL_CRITICAL | 
G_LOG_LEVEL_ERROR,

ERROR: line over 90 characters
#664: FILE: tools/vhost-user-i2c/main.c:597:
+        g_autoptr(GSocket) bind_socket = g_socket_new(G_SOCKET_FAMILY_UNIX, 
G_SOCKET_TYPE_STREAM,

WARNING: line over 80 characters
#665: FILE: tools/vhost-user-i2c/main.c:598:
+                                                      
G_SOCKET_PROTOCOL_DEFAULT, &error);

total: 18 errors, 10 warnings, 686 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/5 Checking commit 9b632f47c605 (docs: add a man page for vhost-user-i2c)
Use of uninitialized value $acpi_testexpected in string eq at 
./scripts/checkpatch.pl line 1529.
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 79 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/5 Checking commit 40ccc271213e (MAINTAINERS: Add entry for virtio-i2c)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
cover.1616570702.git.viresh.kumar@linaro.org/testing.checkpatch/?type=message">http://patchew.org/logs/cover.1616570702.git.viresh.kumar@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com