Re: [PATCH v2] i386/cpu_dump: support AVX512 ZMM regs dump

[no-reply]

Patchew URL: 
1616567465-153141-1-git-send-email-robert.hu@linux.intel.com/">https://patchew.org/QEMU/1616567465-153141-1-git-send-email-robert.hu@linux.intel.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1616567465-153141-1-git-send-email-robert.hu@linux.intel.com
Subject: [PATCH v2] i386/cpu_dump: support AVX512 ZMM regs dump

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/1616567465-153141-1-git-send-email-robert.hu@linux.intel.com -> 
patchew/1616567465-153141-1-git-send-email-robert.hu@linux.intel.com
 - [tag update]      patchew/20210323155132.238193-1-f4bug@amsat.org -> 
patchew/20210323155132.238193-1-f4bug@amsat.org
 - [tag update]      patchew/20210323165308.15244-1-alex.bennee@linaro.org -> 
patchew/20210323165308.15244-1-alex.bennee@linaro.org
 - [tag update]      
patchew/91d5978357fb8709ef61d2030984f7142847037d.1616141556.git.huangy81@chinatelecom.cn
 -> 
patchew/91d5978357fb8709ef61d2030984f7142847037d.1616141556.git.huangy81@chinatelecom.cn
Switched to a new branch 'test'
34024e2 i386/cpu_dump: support AVX512 ZMM regs dump

=== OUTPUT BEGIN ===
ERROR: else should follow close brace '}'
#64: FILE: target/i386/cpu-dump.c:520:
+        }
+        else if (env->xcr0 & XFEATURE_AVX) {

ERROR: else should follow close brace '}'
#76: FILE: target/i386/cpu-dump.c:532:
+        }
+        else { /* SSE and below cases */

ERROR: spaces required around that '|' (ctx:VxE)
#106: FILE: target/i386/cpu.h:259:
+                             XFEATURE_AVX512_ZMM_Hi256| \
                                                       ^

total: 3 errors, 0 warnings, 80 lines checked

Commit 34024e2b18d2 (i386/cpu_dump: support AVX512 ZMM regs dump) has style 
problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
1616567465-153141-1-git-send-email-robert.hu@linux.intel.com/testing.checkpatch/?type=message">http://patchew.org/logs/1616567465-153141-1-git-send-email-robert.hu@linux.intel.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com