[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 03/10] target/ppc: Reduce env->hflags to uint32_t
From: |
David Gibson |
Subject: |
Re: [PATCH v5 03/10] target/ppc: Reduce env->hflags to uint32_t |
Date: |
Wed, 24 Mar 2021 11:03:31 +1100 |
On Tue, Mar 23, 2021 at 12:43:33PM -0600, Richard Henderson wrote:
> It will be stored in tb->flags, which is also uint32_t,
> so let's use the correct size.
>
> Reviewed-by: Cédric Le Goater <clg@kaod.org>
> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Applied to ppc-for-6.0.
> ---
> target/ppc/cpu.h | 4 ++--
> target/ppc/misc_helper.c | 2 +-
> target/ppc/translate.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> index fe6c3f815d..d5f362506a 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -1129,8 +1129,8 @@ struct CPUPPCState {
> bool resume_as_sreset;
> #endif
>
> - /* These resources are used only in QEMU core */
> - target_ulong hflags;
> + /* These resources are used only in TCG */
> + uint32_t hflags;
> target_ulong hflags_compat_nmsr; /* for migration compatibility */
> int immu_idx; /* precomputed MMU index to speed up insn accesses */
> int dmmu_idx; /* precomputed MMU index to speed up data accesses */
> diff --git a/target/ppc/misc_helper.c b/target/ppc/misc_helper.c
> index 63e3147eb4..b04b4d7c6e 100644
> --- a/target/ppc/misc_helper.c
> +++ b/target/ppc/misc_helper.c
> @@ -199,7 +199,7 @@ void helper_store_hid0_601(CPUPPCState *env, target_ulong
> val)
> if ((val ^ hid0) & 0x00000008) {
> /* Change current endianness */
> hreg_compute_hflags(env);
> - qemu_log("%s: set endianness to %c => " TARGET_FMT_lx "\n", __func__,
> + qemu_log("%s: set endianness to %c => %08x\n", __func__,
> val & 0x8 ? 'l' : 'b', env->hflags);
> }
> }
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index a9325a12e5..a85b890bb0 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -7657,7 +7657,7 @@ void ppc_cpu_dump_state(CPUState *cs, FILE *f, int
> flags)
> env->nip, env->lr, env->ctr, cpu_read_xer(env),
> cs->cpu_index);
> qemu_fprintf(f, "MSR " TARGET_FMT_lx " HID0 " TARGET_FMT_lx " HF "
> - TARGET_FMT_lx " iidx %d didx %d\n",
> + "%08x iidx %d didx %d\n",
> env->msr, env->spr[SPR_HID0],
> env->hflags, env->immu_idx, env->dmmu_idx);
> #if !defined(NO_TIMER_DUMP)
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH v5 00/10] target/ppc: Fix truncation of env->hflags, Richard Henderson, 2021/03/23
- [PATCH v5 01/10] target/ppc: Extract post_load_update_msr, Richard Henderson, 2021/03/23
- [PATCH v5 06/10] target/ppc: Put LPCR[GTSE] in hflags, Richard Henderson, 2021/03/23
- [PATCH v5 03/10] target/ppc: Reduce env->hflags to uint32_t, Richard Henderson, 2021/03/23
- Re: [PATCH v5 03/10] target/ppc: Reduce env->hflags to uint32_t,
David Gibson <=
- [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, Richard Henderson, 2021/03/23
- Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, David Gibson, 2021/03/23
- Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, Greg Kurz, 2021/03/29
- Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, Richard Henderson, 2021/03/29
- Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, David Gibson, 2021/03/30
- Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, Richard Henderson, 2021/03/30
- Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, David Gibson, 2021/03/30
- Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, Greg Kurz, 2021/03/31
- Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, David Gibson, 2021/03/31
- Re: [PATCH v5 02/10] target/ppc: Disconnect hflags from MSR, Richard Henderson, 2021/03/31