[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 20/28] qapi/pragma: Streamline comments on member-name-except
From: |
Eric Blake |
Subject: |
Re: [PATCH 20/28] qapi/pragma: Streamline comments on member-name-exceptions |
Date: |
Tue, 23 Mar 2021 10:10:18 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/pragma.json | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
> diff --git a/qapi/pragma.json b/qapi/pragma.json
> index 4895848c5e..4c47c802d1 100644
> --- a/qapi/pragma.json
> +++ b/qapi/pragma.json
> @@ -10,11 +10,13 @@
> 'query-tpm-models',
> 'query-tpm-types',
> 'ringbuf-read' ],
> - 'member-name-exceptions': [
> - 'ACPISlotType', # DIMM, visible through
> query-acpi-ospm-status
> - 'BlockdevVmdkSubformat', # all members, to match VMDK spec
> spellings
> - 'BlockdevVmdkAdapterType', # legacyESX, to match VMDK spec spellings
> - 'QapiErrorClass', # all members, visible through errors
> - 'UuidInfo', # UUID, visible through query-uuid
> - 'X86CPURegister32' # all members, visible indirectly
> through qom-get
> + # Externally visible types whose member names may use uppercase
> + 'member-name-exceptions': [ # visible in:
> + 'ACPISlotType', # query-acpi-ospm-status
> + 'BlockdevVmdkAdapterType', # blockdev-create (to match VMDK spec)
> + 'BlockdevVmdkSubformat', # blockdev-create (to match VMDK spec)
> + 'QapiErrorClass', # QMP error replies
> + 'UuidInfo', # query-uuid
> + 'X86CPURegister32' # qom-get of x86 CPU properties
> + # feature-words, filtered-features
> ] } }
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions, (continued)
- [PATCH 02/28] tests/qapi-schema: Drop redundant flat-union-inline test, Markus Armbruster, 2021/03/23
- [PATCH 09/28] qapi: Lift enum-specific code out of check_name_str(), Markus Armbruster, 2021/03/23
- [PATCH 14/28] qapi: Enforce type naming rules, Markus Armbruster, 2021/03/23
- [PATCH 20/28] qapi/pragma: Streamline comments on member-name-exceptions, Markus Armbruster, 2021/03/23
- Re: [PATCH 20/28] qapi/pragma: Streamline comments on member-name-exceptions,
Eric Blake <=
- [PATCH 06/28] tests/qapi-schema: Tweak to demonstrate buggy member name check, Markus Armbruster, 2021/03/23
[PATCH 05/28] tests/qapi-schema: Drop TODO comment on simple unions, Markus Armbruster, 2021/03/23
[PATCH 04/28] tests/qapi-schema: Belatedly update comment on alternate clash, Markus Armbruster, 2021/03/23
[PATCH 24/28] qapi: Enforce command naming rules, Markus Armbruster, 2021/03/23