[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH 03/28] tests/qapi-schema: Rework comments on longhand member definitions |
|
Date: |
Tue, 23 Mar 2021 08:59:17 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 3/23/21 4:40 AM, Markus Armbruster wrote:
> A few old comments talk about "desired future use of defaults" and
> "anonymous inline branch types". Kind of misleading since commit
> 87adbbffd4 "qapi: add a dictionary form for TYPE" added longhand
> member definitions. Talk about that instead.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/qapi-schema/event-member-invalid-dict.err | 2 +-
> tests/qapi-schema/event-member-invalid-dict.json | 2 ++
> tests/qapi-schema/flat-union-inline-invalid-dict.json | 4 ++--
> tests/qapi-schema/nested-struct-data-invalid-dict.err | 2 +-
> tests/qapi-schema/nested-struct-data-invalid-dict.json | 3 ++-
> tests/qapi-schema/nested-struct-data.json | 2 +-
> tests/qapi-schema/struct-member-invalid-dict.err | 2 +-
> tests/qapi-schema/struct-member-invalid-dict.json | 3 ++-
> 8 files changed, 12 insertions(+), 8 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org