[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] block: Remove monitor command block_passwd
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH] block: Remove monitor command block_passwd |
|
Date: |
Tue, 23 Mar 2021 10:30:48 +0000 |
|
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Tue, Mar 23, 2021 at 11:19:51AM +0100, Markus Armbruster wrote:
> Command block_passwd always fails since
>
> Commit c01c214b69 "block: remove all encryption handling APIs"
> (v2.10.0) turned block_passwd into a stub that always fails, and
> hardcoded encryption_key_missing to false in query-named-block-nodes
> and query-block.
>
> Commit ad1324e044 "block: remove 'encryption_key_missing' flag from
> QAPI" just landed. Complete the cleanup job: remove block_passwd.
Oh, we never marked block_passwd as deprecated, so I missed this
cleanup.
None the less we're fine removing it, since anyone who has tried
to use it since 2.10 will have found it useless, and have been
unable to start their VMs with encrypted disks.
>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> This is based on my "[PATCH 00/28] qapi: Enforce naming rules". To
> apply directly, simply drop the qapi/pragma.json hunk.
>
> Based-on: <20210323094025.3569441-1-armbru@redhat.com>
>
>
> qapi/block-core.json | 14 --------------
> qapi/pragma.json | 1 -
> block/monitor/block-hmp-cmds.c | 10 ----------
> blockdev.c | 8 --------
> hmp-commands.hx | 15 ---------------
> 5 files changed, 48 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|