[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] accel: add cpu_reset
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC] accel: add cpu_reset |
Date: |
Tue, 23 Mar 2021 09:43:57 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/22/21 2:54 PM, Claudio Fontana wrote:
> On 3/22/21 2:42 PM, Philippe Mathieu-Daudé wrote:
>> On 3/22/21 2:27 PM, Claudio Fontana wrote:
>>> XXX
>>> ---
>>> accel/accel-common.c | 9 +++++++++
>>> hw/core/cpu.c | 3 ++-
>>> include/hw/core/accel-cpu.h | 2 ++
>>> include/qemu/accel.h | 6 ++++++
>>> target/i386/cpu.c | 4 ----
>>> target/i386/kvm/kvm-cpu.c | 6 ++++++
>>> 6 files changed, 25 insertions(+), 5 deletions(-)
>>>
>>>
>>> This surprisingly works without moving cpu_reset() to a
>>> specific_ss module, even though
>>>
>>> accel-common.c is specific_ss,
>>> hw/core/cpu.c is common_ss.
>>>
>>> How come the call to accel_reset_cpu works?
>>
>> Each CPU optionally calls cpu_reset() manually?
>
> Hi Philippe, are you concerned about these calls?
> Or what are you highlighting here?
>
> They in turn call cpu_reset() so we should be good right?
I guess I simply misunderstood your question :)
Re: [RFC] accel: add cpu_reset, Philippe Mathieu-Daudé, 2021/03/22
[PATCH v28 01/23] target/i386: Rename helper_fldt, helper_fstt, Claudio Fontana, 2021/03/22
[PATCH v28 02/23] target/i386: Split out do_fsave, do_frstor, do_fxsave, do_fxrstor, Claudio Fontana, 2021/03/22
[PATCH v28 04/23] cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn, Claudio Fontana, 2021/03/22
[PATCH v28 05/23] accel: introduce new accessor functions, Claudio Fontana, 2021/03/22
[PATCH v28 03/23] i386: split cpu accelerators from cpu.c, using AccelCPUClass, Claudio Fontana, 2021/03/22
[PATCH v28 06/23] target/i386: fix host_cpu_adjust_phys_bits error handling, Claudio Fontana, 2021/03/22
[PATCH v28 09/23] i386: split off sysemu-only functionality in tcg-cpu, Claudio Fontana, 2021/03/22
[PATCH v28 07/23] accel-cpu: make cpu_realizefn return a bool, Claudio Fontana, 2021/03/22