Re: [PATCH v2] target/riscv: Prevent lost illegal instruction exceptions

[Richard Henderson]

On 3/22/21 6:16 AM, Georg Kotheimer wrote:
> When decode_insn16() fails, we fall back to decode_RV32_64C() for
> further compressed instruction decoding. However, prior to this change,
> we did not raise an illegal instruction exception, if decode_RV32_64C()
> fails to decode the instruction. This means that we skipped illegal
> compressed instructions instead of raising an illegal instruction
> exception.
>
> Instead of patching decode_RV32_64C(), we can just remove it,
> as it is dead code since f330433b363 anyway.
>
> Signed-off-by: Georg Kotheimer<georg.kotheimer@kernkonzept.com>
> ---
>   target/riscv/translate.c | 179 +--------------------------------------
>   1 file changed, 1 insertion(+), 178 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~