qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 13/17] target/ppc: Remove env->immu_idx and env->dmmu_idx


From: Richard Henderson
Subject: Re: [PATCH v4 13/17] target/ppc: Remove env->immu_idx and env->dmmu_idx
Date: Mon, 22 Mar 2021 11:27:49 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 3/21/21 10:26 PM, David Gibson wrote:
On Mon, Mar 15, 2021 at 12:46:11PM -0600, Richard Henderson wrote:
We weren't recording MSR_GS in hflags, which means that BookE
memory accesses were essentially random vs Guest State.

Instead of adding this bit directly, record the completed mmu
indexes instead.  This makes it obvious that we are recording
exactly the information that we need.

This also means that we can stop directly recording MSR_IR.

What still uses MSR_DR, that you can't also drop it?

#define CHK_HVRM                                            \
    do {                                                    \
        if (unlikely(ctx->pr || !ctx->hv || ctx->dr)) {     \

I have this notion that this (and CHK_HV and CHK_SV) could be a test against mmu_idx instead, but was reluctant to make that change.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]