[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 for-6.0 2/2] tcg: Workaround macOS 11.2 mprotect bug
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v3 for-6.0 2/2] tcg: Workaround macOS 11.2 mprotect bug |
|
Date: |
Mon, 22 Mar 2021 16:39:34 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/22/21 4:00 PM, Richard Henderson wrote:
> On 3/22/21 4:03 AM, Philippe Mathieu-Daudé wrote:
>>> - rc = qemu_mprotect_none(end, page_size);
>>
>> What about:
>>
>> #ifdef CONFIG_DARWIN
>>
>> /* ... */
>> (void)rc;
>> #else
>>
>>> - g_assert(!rc);
>>
>> #endif
>
> What does that buy us, really? It seems like it just clutters the code
> with ifdefs.
No problem.