[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tests/meson: Only build softfloat objects if TCG is selected
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] tests/meson: Only build softfloat objects if TCG is selected |
Date: |
Mon, 22 Mar 2021 14:09:40 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/22/21 1:57 PM, Paolo Bonzini wrote:
> On 22/03/21 12:47, Philippe Mathieu-Daudé wrote:
>> The previous attempt (commit f77147cd4de) doesn't work as
>> expected, as we still have CONFIG_TCG=1 when using:
>>
>> configure --disable-system --disable-user
>
> But there's no change in behavior with this patch, right?
I'm trying to save CI minutes from the build-tools-and-docs-debian
job which uses:
configure --disable-system --disable-user --disable-tools --enable-docs
See https://gitlab.com/qemu-project/qemu/-/jobs/1117005759:
[77/1268] Compiling C object
libqemuutil.a.p/meson-generated_.._trace_trace-qapi.c.o
[645/1268] Compiling C object
tests/fp/libtestfloat.a.p/berkeley-testfloat-3_source_writeCase_a_f32.c.o
[1079/1268] Compiling C object
tests/unit/test-clone-visitor.p/test-clone-visitor.c.o
[1132/1268] Compiling C object tests/unit/test-qdist.p/test-qdist.c.o
>
> I would rather first start removing CONFIG_TCG from target-dependent
> files (such as tests/qtest/bios-tables-test.c and
> tests/qtest/qmp-cmd-test.c), and then just remove the
>
> config_host += { 'CONFIG_TCG': 'y' }
>
> line that is not needed anymore.
You seems right, I missed something, I'll revisit...
Thanks.