[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/5] tests/unit/test-block-iothread: fix maybe-uninitialized error
From: |
Thomas Huth |
Subject: |
[PULL 2/5] tests/unit/test-block-iothread: fix maybe-uninitialized error on GCC 11 |
Date: |
Sun, 21 Mar 2021 18:18:30 +0100 |
From: Emanuele Giuseppe Esposito <eesposit@redhat.com>
When building qemu with GCC 11, test-block-iothread produces the following
warning:
../tests/unit/test-block-iothread.c:148:11: error: ‘buf’ may be used
uninitialized [-Werror=maybe-uninitialized]
This is caused by buf[512] left uninitialized and passed to
bdrv_save_vmstate() that expects a const uint8_t *, so the compiler
assumes it will be read and expects the parameter to be initialized.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20210319112218.49609-1-eesposit@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/unit/test-block-iothread.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/unit/test-block-iothread.c b/tests/unit/test-block-iothread.c
index 3f866a35c6..8cf172cb7a 100644
--- a/tests/unit/test-block-iothread.c
+++ b/tests/unit/test-block-iothread.c
@@ -89,7 +89,7 @@ static void test_sync_op_pread(BdrvChild *c)
static void test_sync_op_pwrite(BdrvChild *c)
{
- uint8_t buf[512];
+ uint8_t buf[512] = { 0 };
int ret;
/* Success */
@@ -117,7 +117,7 @@ static void test_sync_op_blk_pread(BlockBackend *blk)
static void test_sync_op_blk_pwrite(BlockBackend *blk)
{
- uint8_t buf[512];
+ uint8_t buf[512] = { 0 };
int ret;
/* Success */
@@ -141,7 +141,7 @@ static void test_sync_op_load_vmstate(BdrvChild *c)
static void test_sync_op_save_vmstate(BdrvChild *c)
{
- uint8_t buf[512];
+ uint8_t buf[512] = { 0 };
int ret;
/* Error: Driver does not support snapshots */
--
2.27.0
- [PULL 0/5] Unit test fixes + misc OS patches, Thomas Huth, 2021/03/21
- [PULL 3/5] configure: fix for SunOS based systems, Thomas Huth, 2021/03/21
- [PULL 1/5] docs/devel/testing.rst: Fix references to unit tests, Thomas Huth, 2021/03/21
- [PULL 2/5] tests/unit/test-block-iothread: fix maybe-uninitialized error on GCC 11,
Thomas Huth <=
- [PULL 4/5] contrib: ivshmem client and server build fix for SunOS., Thomas Huth, 2021/03/21
- [PULL 5/5] FreeBSD: Upgrade to 12.2 release, Thomas Huth, 2021/03/21
- Re: [PULL 0/5] Unit test fixes + misc OS patches, Peter Maydell, 2021/03/22