[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg
From: |
Andrey Gruzdev |
Subject: |
[PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread |
Date: |
Fri, 19 Mar 2021 17:52:47 +0300 |
Added missing qemu_fflush() on buffer file holding precopy device state.
Increased initial QIOChannelBuffer allocation to 512KB to avoid reallocs.
Typical configurations often require >200KB for device state and VMDESC.
Signed-off-by: Andrey Gruzdev <andrey.gruzdev@virtuozzo.com>
---
migration/migration.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index ca8b97baa5..32b48fe9f5 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -3812,7 +3812,7 @@ static void *bg_migration_thread(void *opaque)
* with vCPUs running and, finally, write stashed non-RAM part of
* the vmstate from the buffer to the migration stream.
*/
- s->bioc = qio_channel_buffer_new(128 * 1024);
+ s->bioc = qio_channel_buffer_new(512 * 1024);
qio_channel_set_name(QIO_CHANNEL(s->bioc), "vmstate-buffer");
fb = qemu_fopen_channel_output(QIO_CHANNEL(s->bioc));
object_unref(OBJECT(s->bioc));
@@ -3866,6 +3866,8 @@ static void *bg_migration_thread(void *opaque)
if (qemu_savevm_state_complete_precopy_non_iterable(fb, false, false)) {
goto fail;
}
+ qemu_fflush(fb);
+
/* Now initialize UFFD context and start tracking RAM writes */
if (ram_write_tracking_start()) {
goto fail;
--
2.25.1
- [PATCH v1 0/3] migration: Fixes to the 'background-snapshot' code, Andrey Gruzdev, 2021/03/19
- [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread,
Andrey Gruzdev <=
- Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread, Peter Xu, 2021/03/22
- Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread, Andrey Gruzdev, 2021/03/23
- Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread, Peter Xu, 2021/03/23
- Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread, Andrey Gruzdev, 2021/03/23
- Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread, Peter Xu, 2021/03/23
- Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread, Andrey Gruzdev, 2021/03/24
- Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread, Dr. David Alan Gilbert, 2021/03/24
- Re: [PATCH v1 1/3] migration: Fix missing qemu_fflush() on buffer file in bg_migration_thread, Peter Xu, 2021/03/24
[PATCH v1 3/3] migration: Pre-fault memory before starting background snasphot, Andrey Gruzdev, 2021/03/19
[PATCH v1 2/3] migration: Inhibit virtio-balloon for the duration of background snapshot, Andrey Gruzdev, 2021/03/19