[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRe
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH] hw/display/bcm2835_fb: Remove DeviceReset() call in DeviceRealize() |
|
Date: |
Fri, 19 Mar 2021 10:35:36 +0000 |
On Sat, 13 Mar 2021 at 17:01, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> When QDev objects have their DeviceReset handler set, they
> shouldn't worry about calling it at realization stage (it
> is handled by hw/core/qdev.c::device_set_realized).
>
> Remove the pointless/confusing bcm2835_fb_reset() call.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/display/bcm2835_fb.c | 2 --
Applied to target-arm.next, thanks.
-- PMM