Re: of AVR target page size

[Dr. David Alan Gilbert]

* Peter Maydell (peter.maydell@linaro.org) wrote:
> On Thu, 18 Mar 2021 at 10:45, Dr. David Alan Gilbert
> <dgilbert@redhat.com> wrote:
> >
> > * Peter Maydell (peter.maydell@linaro.org) wrote:
> > > Also, what does the
> > >  /* 0x80 is reserved in migration.h start with 0x100 next */
> > > comment refer to? migration.h has no instances of "RAM_SAVE"
> > > or 0x80 or 1 << 7...
> >
> > It looks like it got moved to qemu-file.h a few years ago
> > as RAM_SAVE_FLAG_HOOK.
> 
> Could we put the define of RAM_SAVE_FLAG_HOOK in migration.h
> with all the other RAM_SAVE_FLAG defines ? It looks like the two
> places that use it already include migration.h...

Do you mean move the rest of the RAM_SAVE_FLAG_* from migration/ram.c
into migration.h?

We could do - although they're never used by anything else.

Dave

> thanks
> -- PMM
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK