[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base v
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it |
|
Date: |
Wed, 17 Mar 2021 19:23:25 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/17/21 2:17 AM, BALATON Zoltan wrote:
> To allow reusing ISA bridge emulation for vt8231_isa move the device
> state of vt82c686b_isa emulation in an abstract via_isa class. This
> change breaks migration back compatibility but this is not an issue
> for Fuloong2E machine which is not versioned or migration supported.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/isa/vt82c686.c | 70 ++++++++++++++++++++++------------------
> include/hw/pci/pci_ids.h | 2 +-
> 2 files changed, 40 insertions(+), 32 deletions(-)
Now than "hw/usb: Extract VT82C686 UHCI PCI function into a new unit"
is merged as commit 6f2bcd5fc84, this is acceptable IMHO, so:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v10 2/7] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO, (continued)
[PATCH v10 1/7] vt82c686: QOM-ify superio related functionality, BALATON Zoltan, 2021/03/16
[PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it, BALATON Zoltan, 2021/03/16
- Re: [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it,
Philippe Mathieu-Daudé <=
[PATCH v10 6/7] hw/pci-host: Add emulation of Marvell MV64361 PPC system controller, BALATON Zoltan, 2021/03/16
Re: [PATCH v10 0/7] Pegasos2 emulation, David Gibson, 2021/03/22