[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 10/15] plugins: expand inline exec kernel-doc documentation.
From: |
Alex Bennée |
Subject: |
[PULL v2 10/15] plugins: expand inline exec kernel-doc documentation. |
Date: |
Wed, 17 Mar 2021 07:22:11 +0000 |
Remove the extraneous @cb parameter and document the non-atomic nature
of the INLINE_ADD_U64 operation.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210312172821.31647-11-alex.bennee@linaro.org>
diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
index 272d240a8f..a3805bb299 100644
--- a/include/qemu/qemu-plugin.h
+++ b/include/qemu/qemu-plugin.h
@@ -269,6 +269,14 @@ void qemu_plugin_register_vcpu_tb_exec_cb(struct
qemu_plugin_tb *tb,
enum qemu_plugin_cb_flags flags,
void *userdata);
+/**
+ * enum qemu_plugin_op - describes an inline op
+ *
+ * @QEMU_PLUGIN_INLINE_ADD_U64: add an immediate value uint64_t
+ *
+ * Note: currently only a single inline op is supported.
+ */
+
enum qemu_plugin_op {
QEMU_PLUGIN_INLINE_ADD_U64,
};
@@ -283,6 +291,9 @@ enum qemu_plugin_op {
* Insert an inline op to every time a translated unit executes.
* Useful if you just want to increment a single counter somewhere in
* memory.
+ *
+ * Note: ops are not atomic so in multi-threaded/multi-smp situations
+ * you will get inexact results.
*/
void qemu_plugin_register_vcpu_tb_exec_inline(struct qemu_plugin_tb *tb,
enum qemu_plugin_op op,
@@ -305,7 +316,6 @@ void qemu_plugin_register_vcpu_insn_exec_cb(struct
qemu_plugin_insn *insn,
/**
* qemu_plugin_register_vcpu_insn_exec_inline() - insn execution inline op
* @insn: the opaque qemu_plugin_insn handle for an instruction
- * @cb: callback function
* @op: the type of qemu_plugin_op (e.g. ADD_U64)
* @ptr: the target memory location for the op
* @imm: the op data (e.g. 1)
--
2.20.1
- Re: [PULL v2 01/15] utils: Use fixed-point arithmetic in qemu_strtosz, (continued)
- [PULL v2 03/15] plugins: Expose physical addresses instead of device offsets, Alex Bennée, 2021/03/17
- [PULL v2 04/15] plugins: expand kernel-doc for qemu_info_t, Alex Bennée, 2021/03/17
- [PULL v2 02/15] plugins: new syscalls plugin, Alex Bennée, 2021/03/17
- [PULL v2 08/15] plugins: add qemu_plugin_cb_flags to kernel-doc, Alex Bennée, 2021/03/17
- [PULL v2 07/15] plugins: expand the typedef kernel-docs for translation, Alex Bennée, 2021/03/17
- [PULL v2 05/15] plugins: cleanup kernel-doc for qemu_plugin_install, Alex Bennée, 2021/03/17
- [PULL v2 06/15] plugins: expand the callback typedef kernel-docs, Alex Bennée, 2021/03/17
- [PULL v2 09/15] plugins: add qemu_plugin_id_t to kernel-doc, Alex Bennée, 2021/03/17
- [PULL v2 12/15] plugins: expand kernel-doc for memory query and instrumentation, Alex Bennée, 2021/03/17
- [PULL v2 10/15] plugins: expand inline exec kernel-doc documentation.,
Alex Bennée <=
- [PULL v2 11/15] plugins: expand kernel-doc for instruction query and instrumentation, Alex Bennée, 2021/03/17
- [PULL v2 13/15] plugins: getting qemu_plugin_get_hwaddr only expose one function prototype, Alex Bennée, 2021/03/17
- [PULL v2 15/15] hw/core: Only build guest-loader if libfdt is available, Alex Bennée, 2021/03/17
- [PULL v2 14/15] plugins: Fixes typo in qemu-plugin.h, Alex Bennée, 2021/03/17
- Re: [PULL v2 00/15] misc fixes (strtoz, plugins, guest-loader), Peter Maydell, 2021/03/18