[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 09/12] hw/net: pcnet: Remove the logic of padding short frames
From: |
Bin Meng |
Subject: |
[PATCH v5 09/12] hw/net: pcnet: Remove the logic of padding short frames in the receive path |
Date: |
Wed, 17 Mar 2021 14:26:35 +0800 |
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
(no changes since v1)
hw/net/pcnet.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c
index dcd3fc4948..044528385e 100644
--- a/hw/net/pcnet.c
+++ b/hw/net/pcnet.c
@@ -987,7 +987,6 @@ ssize_t pcnet_receive(NetClientState *nc, const uint8_t
*buf, size_t size_)
{
PCNetState *s = qemu_get_nic_opaque(nc);
int is_padr = 0, is_bcast = 0, is_ladr = 0;
- uint8_t buf1[60];
int remaining;
int crc_err = 0;
size_t size = size_;
@@ -1000,14 +999,6 @@ ssize_t pcnet_receive(NetClientState *nc, const uint8_t
*buf, size_t size_)
printf("pcnet_receive size=%zu\n", size);
#endif
- /* if too small buffer, then expand it */
- if (size < MIN_BUF_SIZE) {
- memcpy(buf1, buf, size);
- memset(buf1 + size, 0, MIN_BUF_SIZE - size);
- buf = buf1;
- size = MIN_BUF_SIZE;
- }
-
if (CSR_PROM(s)
|| (is_padr=padr_match(s, buf, size))
|| (is_bcast=padr_bcast(s, buf, size))
--
2.17.1
- [PATCH v5 00/12] net: Pad short frames for network backends, Bin Meng, 2021/03/17
- [PATCH v5 01/12] net: eth: Add a helper to pad a short Ethernet frame, Bin Meng, 2021/03/17
- [PATCH v5 02/12] net: Add a 'do_not_pad" to NetClientState, Bin Meng, 2021/03/17
- [PATCH v5 03/12] net: Pad short frames to minimum size before sending from SLiRP/TAP, Bin Meng, 2021/03/17
- [PATCH v5 04/12] hw/net: virtio-net: Initialize nc->do_not_pad to true, Bin Meng, 2021/03/17
- [PATCH v5 05/12] hw/net: e1000: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/17
- [PATCH v5 06/12] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/17
- [PATCH v5 08/12] hw/net: ne2000: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/17
- [PATCH v5 07/12] hw/net: i82596: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/17
- [PATCH v5 09/12] hw/net: pcnet: Remove the logic of padding short frames in the receive path,
Bin Meng <=
- [PATCH v5 10/12] hw/net: rtl8139: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/17
- [PATCH v5 11/12] hw/net: sungem: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/17
- [PATCH v5 12/12] hw/net: sunhme: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/17
- Re: [PATCH v5 00/12] net: Pad short frames for network backends, Bin Meng, 2021/03/21
- Re: [PATCH v5 00/12] net: Pad short frames for network backends, Jason Wang, 2021/03/22