[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 42/57] tcg/tci: Split out tcg_out_op_r[iI]
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v5 42/57] tcg/tci: Split out tcg_out_op_r[iI] |
Date: |
Wed, 17 Mar 2021 00:39:45 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
"And support mov_i64 on 32-bit host"?
On 3/11/21 3:39 PM, Richard Henderson wrote:
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tci/tcg-target.c.inc | 50 ++++++++++++++++++++++++++++------------
> 1 file changed, 35 insertions(+), 15 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> static void tcg_out_movi(TCGContext *s, TCGType type,
> - TCGReg t0, tcg_target_long arg)
> + TCGReg ret, tcg_target_long arg)
> {
> - uint8_t *old_code_ptr = s->code_ptr;
> - uint32_t arg32 = arg;
> - if (type == TCG_TYPE_I32 || arg == arg32) {
> - tcg_out_op_t(s, INDEX_op_tci_movi_i32);
> - tcg_out_r(s, t0);
> - tcg_out32(s, arg32);
> - } else {
> - tcg_debug_assert(type == TCG_TYPE_I64);
> + switch (type) {
> + case TCG_TYPE_I32:
> + tcg_out_op_ri(s, INDEX_op_tci_movi_i32, ret, arg);
> + break;
> #if TCG_TARGET_REG_BITS == 64
> - tcg_out_op_t(s, INDEX_op_tci_movi_i64);
> - tcg_out_r(s, t0);
> - tcg_out64(s, arg);
> -#else
> - TODO();
> + case TCG_TYPE_I64:
> + tcg_out_op_rI(s, INDEX_op_tci_movi_i64, ret, arg);
> + break;
> #endif
> + default:
> + g_assert_not_reached();
> }
> - old_code_ptr[1] = s->code_ptr - old_code_ptr;
> }
>
> static void tcg_out_call(TCGContext *s, const tcg_insn_unit *arg)
>
- [PATCH v5 41/57] tcg/tci: Split out tcg_out_op_np, (continued)
- [PATCH v5 41/57] tcg/tci: Split out tcg_out_op_np, Richard Henderson, 2021/03/11
- [PATCH v5 37/57] tcg/tci: Split out tcg_out_op_rrrr, Richard Henderson, 2021/03/11
- [PATCH v5 43/57] tcg/tci: Reserve r13 for a temporary, Richard Henderson, 2021/03/11
- [PATCH v5 44/57] tcg/tci: Emit setcond before brcond, Richard Henderson, 2021/03/11
- [PATCH v5 45/57] tcg/tci: Remove tci_write_reg, Richard Henderson, 2021/03/11
- [PATCH v5 40/57] tcg/tci: Split out tcg_out_op_v, Richard Henderson, 2021/03/11
- [PATCH v5 42/57] tcg/tci: Split out tcg_out_op_r[iI], Richard Henderson, 2021/03/11
- Re: [PATCH v5 42/57] tcg/tci: Split out tcg_out_op_r[iI],
Philippe Mathieu-Daudé <=
- [PATCH v5 50/57] tcg/tci: Implement extract, sextract, Richard Henderson, 2021/03/11
- [PATCH v5 51/57] tcg/tci: Implement clz, ctz, ctpop, Richard Henderson, 2021/03/11
- [PATCH v5 47/57] tcg/tci: Implement goto_ptr, Richard Henderson, 2021/03/11
- [PATCH v5 48/57] tcg/tci: Implement movcond, Richard Henderson, 2021/03/11
- [PATCH v5 49/57] tcg/tci: Implement andc, orc, eqv, nand, nor, Richard Henderson, 2021/03/11
- [PATCH v5 46/57] tcg/tci: Change encoding to uint32_t units, Richard Henderson, 2021/03/11
- [PATCH v5 54/57] tcg/tci: Split out tci_qemu_ld, tci_qemu_st, Richard Henderson, 2021/03/11
- [PATCH v5 56/57] gitlab: Rename ACCEL_CONFIGURE_OPTS to EXTRA_CONFIGURE_OPTS, Richard Henderson, 2021/03/11