Re: [PATCH v5 00/13] hw/block/nvme: metadata and end-to-end data protection support

[Klaus Jensen]

On Mar 10 10:53, Klaus Jensen wrote:
> From: Klaus Jensen <k.jensen@samsung.com>
> 
> This is v5 of a series that adds support for metadata and end-to-end
> data protection.
> 
> First, on the subject of metadata, in v1, support was restricted to
> extended logical blocks, which was pretty trivial to implement, but
> required special initialization and broke DULBE. In v2, metadata is
> always stored continuously at the end of the underlying block device.
> This has the advantage of not breaking DULBE since the data blocks
> remains aligned and allows bdrv_block_status to be used to determinate
> allocation status. It comes at the expense of complicating the extended
> LBA emulation, but on the other hand it also gains support for metadata
> transfered as a separate buffer.
> 
> The end-to-end data protection support blew up in terms of required
> changes. This is due to the fact that a bunch of new commands has been
> added to the device since v1 (zone append, compare, copy), and they all
> require various special handling for protection information. If
> potential reviewers would like it split up into multiple patches, each
> adding pi support to one command, shout out.
> 
> Support for metadata and end-to-end data protection is all joint work
> with Gollu Appalanaidu.
> 
> v5:
>   * add a required fix for zone management receive when metadata is
>     involved
>   * add a couple of refactor patches for the zoned init code to make the
>     format nvm patch more straight forward wrt. formatting of zoned
>     namespaces.
> 

FYI, the SPDK e2edp test (tests/nvme/e2edp/nvme_dp) fails on this series
when metadata is more than 8 bytes. This is a bug in the test and I've
posted a fix upstream for this.

  https://review.spdk.io/gerrit/c/spdk/spdk/+/6891


--
k

signature.asc
Description: PGP signature