qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/8] hw/audio/fmopl.c: Replaced calls to malloc with GLib's v


From: Mahmoud Mandour
Subject: Re: [PATCH 3/8] hw/audio/fmopl.c: Replaced calls to malloc with GLib's variants
Date: Mon, 15 Mar 2021 19:35:07 +0200

Thank you for the valuable feedback. I tried as much as I could to maintain
the semantics as is, only changing the calls to GLib's functions.

To assure myself that I understood the directions of your feedback, the initialization
of the tables can be done using g_malloc directly and all the null checks for the tables
to be dropped. And that's because of the cruciality of this initialization code. 

Can you please elaborate more on how I would employ g_autofree in this code? Are 
you talking about the memory allocated for ``ptr`` in OPLCreate here?

Thanks
Mahmoud Mandour

reply via email to

[Prev in Thread] Current Thread [Next in Thread]