RE: [PATCH v8 27/35] Hexagon (target/hexagon) TCG for instructions with multiple definitions

[Taylor Simpson]

> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Sunday, February 14, 2021 6:34 PM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: philmd@redhat.com; alex.bennee@linaro.org; laurent@vivier.eu;
> ale@rev.ng; Brian Cain <bcain@quicinc.com>
> Subject: Re: [PATCH v8 27/35] Hexagon (target/hexagon) TCG for instructions
> with multiple definitions
>
> On 2/7/21 9:46 PM, Taylor Simpson wrote:
> > +#define fGEN_TCG_L2_loadrub_pr(SHORTCODE)      SHORTCODE
> > +#define fGEN_TCG_L2_loadrub_pi(SHORTCODE)      SHORTCODE
> > +#define fGEN_TCG_L2_loadrb_pr(SHORTCODE)       SHORTCODE
> > +#define fGEN_TCG_L2_loadrb_pi(SHORTCODE)       SHORTCODE;
> > +#define fGEN_TCG_L2_loadruh_pr(SHORTCODE)      SHORTCODE
> > +#define fGEN_TCG_L2_loadruh_pi(SHORTCODE)      SHORTCODE;
>
> Why have some of these ; but not all?

The initial series only has overrides that are required for correct execution.  
I did that to minimize the amount of code to review.  For most loads, the 
helper version works correctly.  These need to be overridden because they 
define two results (the value loaded and the updated pointer).  I have written 
the overrides for all and will upstream them in the future.

Here is my roadmap for Hexagon patches
- Address your feedback on the v8 series
- Add the remaining scalar core instructions
- Add the Hexagon Vector eXtensions (HVX) instructions
- Additional overrides, including these


Thanks,
Taylor