qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes


From: Taylor Simpson
Subject: RE: [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes
Date: Sun, 14 Mar 2021 00:39:17 +0000


> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Sunday, February 14, 2021 5:41 PM
> To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> Cc: philmd@redhat.com; alex.bennee@linaro.org; laurent@vivier.eu;
> ale@rev.ng; Brian Cain <bcain@quicinc.com>
> Subject: Re: [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes
>
> On 2/7/21 9:46 PM, Taylor Simpson wrote:
> > +    } else if ((itype == ICLASS_V2LDST) && (GET_ATTRIB(opcode,
> A_STORE))) {
> > +        return SLOTS_01;
> > +    } else if ((itype == ICLASS_V2LDST) && (!GET_ATTRIB(opcode,
> A_STORE))) {
> > +        return SLOTS_01;
>
> What's the point of this?  Between the two all ICLASS_V2LDST use SLOTS_01.
> Why
> can't it be done in
>
> > +        return iclass_info[itype];

Good catch - I'll eliminate the unnecessary checks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]