Re: [PATCH 16/26] tcg: Move MAX_CODE_GEN_BUFFER_SIZE to tcg-target.h

[Richard Henderson]

On 3/10/21 6:42 PM, BALATON Zoltan wrote:
> > -/* Minimum size of the code gen buffer.  This number is randomly chosen,
> > -   but not so small that we can't have a fair number of TB's live.  */
> > +/*
> > + * Minimum size of the code gen buffer.  This number is randomly chosen,
> > + * but not so small that we can't have a fair number of TB's live.
> > + *
> > + * Maximum size is defined in tcg-target.h.
> > + */
> > #define MIN_CODE_GEN_BUFFER_SIZE     (1 * MiB)
> >
> > -/* Maximum size of the code gen buffer we'd like to use.  Unless otherwise
> > -   indicated, this is constrained by the range of direct branches on the
> > -   host cpu, as used by the TCG implementation of goto_tb.  */
>
> This comment about constraints seems to have been lost. Should it be preserved 
> above?

Done.


r~