[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 1/5] linux-user: Fix executable page of /proc/self/maps
From: |
Laurent Vivier |
Subject: |
[PULL 1/5] linux-user: Fix executable page of /proc/self/maps |
Date: |
Sat, 13 Mar 2021 10:47:43 +0100 |
From: Nicolas Surbayrole <nsurbayrole@quarkslab.com>
The guest binary and libraries are not always map with the
executable bit in the host process. The guest may read a
/proc/self/maps with no executable address range. The
perm fields should be based on the guest permission inside
Qemu.
Signed-off-by: Nicolas Surbayrole <nsurbayrole@quarkslab.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20210308091959.986540-1-nsurbayrole@quarkslab.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
linux-user/syscall.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 9522f603aad6..1e508576c73e 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -7890,9 +7890,9 @@ static int open_self_maps(void *cpu_env, int fd)
count = dprintf(fd, TARGET_ABI_FMT_ptr "-" TARGET_ABI_FMT_ptr
" %c%c%c%c %08" PRIx64 " %s %"PRId64,
h2g(min), h2g(max - 1) + 1,
- e->is_read ? 'r' : '-',
- e->is_write ? 'w' : '-',
- e->is_exec ? 'x' : '-',
+ (flags & PAGE_READ) ? 'r' : '-',
+ (flags & PAGE_WRITE_ORG) ? 'w' : '-',
+ (flags & PAGE_EXEC) ? 'x' : '-',
e->is_priv ? 'p' : '-',
(uint64_t) e->offset, e->dev, e->inode);
if (path) {
--
2.29.2
- [PULL 0/5] Linux user for 6.0 patches, Laurent Vivier, 2021/03/13
- [PULL 4/5] linux-user/elfload: do not assume MAP_FIXED_NOREPLACE kernel support, Laurent Vivier, 2021/03/13
- [PULL 1/5] linux-user: Fix executable page of /proc/self/maps,
Laurent Vivier <=
- [PULL 3/5] linux-user/elfload: munmap proper address in pgd_find_hole_fallback, Laurent Vivier, 2021/03/13
- [PULL 2/5] linux-user: manage binfmt-misc preserve-arg[0] flag, Laurent Vivier, 2021/03/13
- [PULL 5/5] linux-user/elfload: fix address calculation in fallback scenario, Laurent Vivier, 2021/03/13
- Re: [PULL 0/5] Linux user for 6.0 patches, no-reply, 2021/03/13
- Re: [PULL 0/5] Linux user for 6.0 patches, Peter Maydell, 2021/03/14