|
From: | Paolo Bonzini |
Subject: | Re: [PATCH 2/3] qom: move user_creatable_add_opts logic to vl.c and QAPIfy it |
Date: | Sat, 13 Mar 2021 10:40:18 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 13/03/21 10:35, Markus Armbruster wrote:
+ object_option_foreach_add(object_create_late, &error_fatal);Likewise. Before and after the patch, object_create_late(opt) == !object_create_early(opt). Your patch provides us with an opportunity to assert this: object_opts must be empty now. Suggestion, not demand.
Nice idea, I'll include it. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |