[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] hexagon: do not specify Python scripts as inputs
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 1/4] hexagon: do not specify Python scripts as inputs |
|
Date: |
Wed, 10 Mar 2021 11:56:04 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 3/10/21 11:49 AM, Paolo Bonzini wrote:
> Python scripts are not inputs, and putting them in @INPUT@. This
> puts requirements on the command line format, keeping all inputs
> close to the name of the script. Avoid that by not including the
> script in the command and not in the inputs.
>
> Also wrap "PYTHONPATH" usage with "env", since setting the environment
> this way is not valid under Windows.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> target/hexagon/meson.build | 30 ++++++++++--------------------
> 1 file changed, 10 insertions(+), 20 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>