Re: [PATCH 1/7] mac_via: switch rtc pram trace-events to use hex rather than decimal for addresses

[Laurent Vivier]

Le 10/03/2021 à 09:09, Mark Cave-Ayland a écrit :
> Since all the documentation uses the hex offsets, this makes it much easier
> to see what is going on.
> 
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/misc/trace-events | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/misc/trace-events b/hw/misc/trace-events
> index d626b9d7a7..73191b5e9d 100644
> --- a/hw/misc/trace-events
> +++ b/hw/misc/trace-events
> @@ -221,8 +221,8 @@ via1_rtc_cmd_test_write(int value) "value=0x%02x"
>  via1_rtc_cmd_wprotect_write(int value) "value=0x%02x"
>  via1_rtc_cmd_pram_read(int addr, int value) "addr=%u value=0x%02x"
>  via1_rtc_cmd_pram_write(int addr, int value) "addr=%u value=0x%02x"
> -via1_rtc_cmd_pram_sect_read(int sector, int offset, int addr, int value) 
> "sector=%u offset=%u addr=%d value=0x%02x"
> -via1_rtc_cmd_pram_sect_write(int sector, int offset, int addr, int value) 
> "sector=%u offset=%u addr=%d value=0x%02x"
> +via1_rtc_cmd_pram_sect_read(int sector, int offset, int addr, int value) 
> "sector=%u offset=%u addr=0x%x value=0x%02x"
> +via1_rtc_cmd_pram_sect_write(int sector, int offset, int addr, int value) 
> "sector=%u offset=%u addr=0x%x value=0x%02x"
>  via1_adb_send(const char *state, uint8_t data, const char *vadbint) "state 
> %s data=0x%02x vADBInt=%s"
>  via1_adb_receive(const char *state, uint8_t data, const char *vadbint, int 
> status, int index, int size) "state %s data=0x%02x vADBInt=%s status=0x%x 
> index=%d size=%d"
>  via1_adb_poll(uint8_t data, const char *vadbint, int status, int index, int 
> size) "data=0x%02x vADBInt=%s status=0x%x index=%d size=%d"
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>