[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] hw/lm32/Kconfig: Have MILKYMIST select LM32_DEVICES
From: |
Laurent Vivier |
Subject: |
Re: [PATCH v2 3/3] hw/lm32/Kconfig: Have MILKYMIST select LM32_DEVICES |
Date: |
Tue, 9 Mar 2021 22:37:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
Le 21/02/2021 à 23:56, Philippe Mathieu-Daudé a écrit :
> The Milkymist board requires more than the PTIMER. Directly
> select the LM32_DEVICES. This fixes:
>
> /usr/bin/ld:
> libqemu-lm32-softmmu.fa.p/target_lm32_gdbstub.c.o: in function
> `lm32_cpu_gdb_read_register':
> target/lm32/gdbstub.c:46: undefined reference to `lm32_pic_get_im'
> target/lm32/gdbstub.c:48: undefined reference to `lm32_pic_get_ip'
> libqemu-lm32-softmmu.fa.p/target_lm32_op_helper.c.o: in function
> `helper_wcsr_im':
> target/lm32/op_helper.c:107: undefined reference to `lm32_pic_set_im'
> libqemu-lm32-softmmu.fa.p/target_lm32_op_helper.c.o: in function
> `helper_wcsr_ip':
> target/lm32/op_helper.c:114: undefined reference to `lm32_pic_set_ip'
> libqemu-lm32-softmmu.fa.p/target_lm32_op_helper.c.o: in function
> `helper_wcsr_jtx':
> target/lm32/op_helper.c:120: undefined reference to `lm32_juart_set_jtx'
> libqemu-lm32-softmmu.fa.p/target_lm32_op_helper.c.o: in function
> `helper_wcsr_jrx':
> target/lm32/op_helper.c:125: undefined reference to `lm32_juart_set_jrx'
> libqemu-lm32-softmmu.fa.p/target_lm32_translate.c.o: in function
> `lm32_cpu_dump_state':
> target/lm32/translate.c:1161: undefined reference to `lm32_pic_get_ip'
> target/lm32/translate.c:1161: undefined reference to `lm32_pic_get_im'
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> hw/lm32/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/lm32/Kconfig b/hw/lm32/Kconfig
> index 518c84ed508..8ac94205d71 100644
> --- a/hw/lm32/Kconfig
> +++ b/hw/lm32/Kconfig
> @@ -6,11 +6,11 @@ config MILKYMIST
> bool
> # FIXME: disabling it results in compile-time errors
> select MILKYMIST_TMU2 if OPENGL && X11
> - select PTIMER
> select PFLASH_CFI01
> select FRAMEBUFFER
> select SD
> select USB_OHCI
> + select LM32_DEVICES
>
> config LM32_EVR
> bool
>
Applied to my trivial-patches branch.
Thanks,
Laurent
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 3/3] hw/lm32/Kconfig: Have MILKYMIST select LM32_DEVICES,
Laurent Vivier <=