[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] storage-daemon: Call job_cancel_sync_all() on shutdown
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] storage-daemon: Call job_cancel_sync_all() on shutdown |
|
Date: |
Tue, 9 Mar 2021 08:46:04 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 |
On 3/9/21 6:18 AM, Kevin Wolf wrote:
> bdrv_close_all() asserts that no jobs are running any more, so we need
> to cancel all jobs first to avoid failing the assertion.
>
> Fixes: b55a3c8860b763b62b2cc2f4a6f55379977bbde5
> Reported-by: Nini Gu <ngu@redhat.com>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> storage-daemon/qemu-storage-daemon.c | 1 +
> tests/qemu-iotests/tests/qsd-jobs | 66 +++++++++++++++++++++++++++
> tests/qemu-iotests/tests/qsd-jobs.out | 22 +++++++++
> 3 files changed, 89 insertions(+)
> create mode 100755 tests/qemu-iotests/tests/qsd-jobs
> create mode 100644 tests/qemu-iotests/tests/qsd-jobs.out
Reviewed-by: Eric Blake <eblake@redhat.com>
> +++ b/tests/qemu-iotests/tests/qsd-jobs
Yay for nicer iotest names ;)
> +seq="$(basename $0)"
> +echo "QA output created by $seq"
$seq is a bit of a misnomer, now, but such is life.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org