[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 06/14] scripts/ci/gitlab-pipeline-status: split utlity function fo
From: |
Thomas Huth |
Subject: |
[PULL 06/14] scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET |
Date: |
Tue, 9 Mar 2021 11:46:09 +0100 |
From: Cleber Rosa <crosa@redhat.com>
This simply splits out the code that does an HTTP GET so that it
can be used for other API requests.
Signed-off-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
Message-Id: <20210222193240.921250-2-crosa@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/ci/gitlab-pipeline-status | 17 ++++++++++++-----
1 file changed, 12 insertions(+), 5 deletions(-)
diff --git a/scripts/ci/gitlab-pipeline-status
b/scripts/ci/gitlab-pipeline-status
index 78e72f6008..0c1e8bd8a7 100755
--- a/scripts/ci/gitlab-pipeline-status
+++ b/scripts/ci/gitlab-pipeline-status
@@ -48,18 +48,25 @@ def get_local_branch_commit(branch):
return result
-def get_pipeline_status(project_id, commit_sha1):
+def get_json_http_response(url):
"""
- Returns the JSON content of the pipeline status API response
+ Returns the JSON content of an HTTP GET request to gitlab.com
"""
- url = '/api/v4/projects/{}/pipelines?sha={}'.format(project_id,
- commit_sha1)
connection = http.client.HTTPSConnection('gitlab.com')
connection.request('GET', url=url)
response = connection.getresponse()
if response.code != http.HTTPStatus.OK:
raise CommunicationFailure("Failed to receive a successful response")
- json_response = json.loads(response.read())
+ return json.loads(response.read())
+
+
+def get_pipeline_status(project_id, commit_sha1):
+ """
+ Returns the JSON content of the pipeline status API response
+ """
+ url = '/api/v4/projects/{}/pipelines?sha={}'.format(project_id,
+ commit_sha1)
+ json_response = get_json_http_response(url)
# As far as I can tell, there should be only one pipeline for the same
# project + commit. If this assumption is false, we can add further
--
2.27.0
- [PULL 00/14] Gitlab, testing and misc patches, Thomas Huth, 2021/03/09
- [PULL 02/14] docker: Alpine build job depends on Alpine container, Thomas Huth, 2021/03/09
- [PULL 03/14] docker: EDK2 build job depends on EDK2 container, Thomas Huth, 2021/03/09
- [PULL 01/14] qtest: delete superfluous inclusions of qtest.h, Thomas Huth, 2021/03/09
- [PULL 04/14] docker: OpenSBI build job depends on OpenSBI container, Thomas Huth, 2021/03/09
- [PULL 05/14] meson: Re-enable the possibility to run "make check SPEED=slow", Thomas Huth, 2021/03/09
- [PULL 06/14] scripts/ci/gitlab-pipeline-status: split utlity function for HTTP GET,
Thomas Huth <=
- [PULL 07/14] scripts/ci/gitlab-pipeline-status: give more information on failures, Thomas Huth, 2021/03/09
- [PULL 08/14] scripts/ci/gitlab-pipeline-status: give more info when pipeline not found, Thomas Huth, 2021/03/09
- [PULL 09/14] libqos/qgraph: format qgraph comments for sphinx documentation, Thomas Huth, 2021/03/09
- [PULL 10/14] docs/devel/qgraph: improve qgraph documentation, Thomas Huth, 2021/03/09
- [PULL 11/14] Acceptance Tests: restore downloading of VM images, Thomas Huth, 2021/03/09
- [PULL 12/14] Acceptance Tests: restore filtering of tests by target arch, Thomas Huth, 2021/03/09
- [PULL 14/14] bsd-user: Add new maintainers, Thomas Huth, 2021/03/09
- [PULL 13/14] Remove deprecated target tilegx, Thomas Huth, 2021/03/09
- Re: [PULL 00/14] Gitlab, testing and misc patches, no-reply, 2021/03/09
- Re: [PULL 00/14] Gitlab, testing and misc patches, Peter Maydell, 2021/03/10