Re: [PATCH] hw/ppc: e500: Add missing <ranges> in the eTSEC node

[Bin Meng]

On Wed, Feb 24, 2021 at 5:28 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> The eTSEC node should provide an empty <ranges> property in the
> eTSEC node, otherwise of_translate_address() in the Linux kernel
> fails to get the eTSEC register base, reporting:
>
>   OF: ** translation for device /platform@f00000000/ethernet@0/queue-group **
>   OF: bus is default (na=1, ns=1) on /platform@f00000000/ethernet@0
>   OF: translating address: 00000000
>   OF: parent bus is default (na=1, ns=1) on /platform@f00000000
>   OF: no ranges; cannot translate
>
> Per devicetree spec v0.3 [1] chapter 2.3.8:
>
>   If the property is not present in a bus node, it is assumed that
>   no mapping exists between children of the node and the parent
>   address space.
>
> This is why of_translate_address() aborts the address translation.
> Apparently U-Boot devicetree parser seems to be tolerant with
> missing <ranges> as this was not noticed when testing with U-Boot.
> The empty <ranges> property is present in all kernel shipped dtsi
> files for eTSEC, Let's add it to conform with the spec.
>
> [1] 
> https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf
>
> Fixes: fdfb7f2cdb2d ("e500: Add support for eTSEC in device tree")
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
>  hw/ppc/e500.c | 1 +
>  1 file changed, 1 insertion(+)
>

Ping?