[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v22 00/17] i386 cleanup PART 2
|
From: |
no-reply |
|
Subject: |
Re: [PATCH v22 00/17] i386 cleanup PART 2 |
|
Date: |
Wed, 24 Feb 2021 06:12:58 -0800 (PST) |
Patchew URL: 20210224133428.14071-1-cfontana@suse.de/">https://patchew.org/QEMU/20210224133428.14071-1-cfontana@suse.de/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20210224133428.14071-1-cfontana@suse.de
Subject: [PATCH v22 00/17] i386 cleanup PART 2
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20210224101442.1837475-1-armbru@redhat.com ->
patchew/20210224101442.1837475-1-armbru@redhat.com
* [new tag] patchew/20210224133428.14071-1-cfontana@suse.de ->
patchew/20210224133428.14071-1-cfontana@suse.de
Switched to a new branch 'test'
10e4e70 i386: move cpu_load_efer into sysemu-only section of cpu.h
f32fe53 i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU
02f72ad i386: split off sysemu part of cpu.c
6949276 i386: split seg_helper into user-only and sysemu parts
bad90cd i386: split svm_helper into sysemu and stub-only user
46a9e57 i386: separate fpu_helper into user and sysemu parts
f31a404 i386: split misc helper into user and sysemu parts
5b0c9ae i386: move TCG btp_helper into sysemu/
2e907c6 i386: split tcg excp_helper into sysemu and user parts
9f05cce i386: split smm helper (sysemu)
e98e38a i386: split off sysemu-only functionality in tcg-cpu
128e7dd meson: add target_user_arch
41d1fb8 accel-cpu: make cpu_realizefn return a bool
1db84c9 target/i386: fix host_cpu_adjust_phys_bits error handling
66f22ce accel: introduce new accessor functions
6823e0e cpu: call AccelCPUClass::cpu_realizefn in cpu_exec_realizefn
5ec899f i386: split cpu accelerators from cpu.c, using AccelCPUClass
=== OUTPUT BEGIN ===
1/17 Checking commit 5ec899f8163a (i386: split cpu accelerators from cpu.c,
using AccelCPUClass)
WARNING: line over 80 characters
#1336: FILE: target/i386/tcg/tcg-cpu.c:125:
+ memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem,
0);
total: 0 errors, 1 warnings, 1256 lines checked
Patch 1/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/17 Checking commit 6823e0e129c5 (cpu: call AccelCPUClass::cpu_realizefn in
cpu_exec_realizefn)
3/17 Checking commit 66f22cec1cb2 (accel: introduce new accessor functions)
4/17 Checking commit 1db84c9940c1 (target/i386: fix host_cpu_adjust_phys_bits
error handling)
5/17 Checking commit 41d1fb8c6e32 (accel-cpu: make cpu_realizefn return a bool)
6/17 Checking commit 128e7ddc295d (meson: add target_user_arch)
7/17 Checking commit e98e38a330f8 (i386: split off sysemu-only functionality in
tcg-cpu)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30:
new file mode 100644
WARNING: line over 80 characters
#115: FILE: target/i386/tcg/sysemu/tcg-cpu.c:72:
+ memory_region_add_subregion_overlap(cpu->cpu_as_root, 0, cpu->cpu_as_mem,
0);
total: 0 errors, 2 warnings, 212 lines checked
Patch 7/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/17 Checking commit 9f05cce71962 (i386: split smm helper (sysemu))
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#23:
target/i386/tcg/{ => sysemu}/smm_helper.c | 19 ++-----------------
total: 0 errors, 1 warnings, 84 lines checked
Patch 8/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/17 Checking commit 2e907c6d4857 (i386: split tcg excp_helper into sysemu and
user parts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#598:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#755: FILE: target/i386/tcg/sysemu/excp_helper.c:153:
+ /* Bits 20-13 provide bits 39-32 of the address, bit 21 is
reserved.
WARNING: Block comments use a leading /* on a separate line
#829: FILE: target/i386/tcg/sysemu/excp_helper.c:227:
+/* return value:
WARNING: line over 80 characters
#930: FILE: target/i386/tcg/sysemu/excp_helper.c:328:
+ pdpe_addr = ((pml4e & PG_ADDRESS_MASK) + (((addr >> 30) & 0x1ff)
<< 3)) &
WARNING: Block comments use a leading /* on a separate line
#1024: FILE: target/i386/tcg/sysemu/excp_helper.c:422:
+ /* Bits 20-13 provide bits 39-32 of the address, bit 21 is
reserved.
WARNING: Block comments use a leading /* on a separate line
#1119: FILE: target/i386/tcg/sysemu/excp_helper.c:517:
+ /* only set write access if already dirty... otherwise wait
WARNING: Block comments use * on subsequent lines
#1120: FILE: target/i386/tcg/sysemu/excp_helper.c:518:
+ /* only set write access if already dirty... otherwise wait
+ for dirty access */
WARNING: Block comments use a trailing */ on a separate line
#1120: FILE: target/i386/tcg/sysemu/excp_helper.c:518:
+ for dirty access */
WARNING: Block comments use a leading /* on a separate line
#1133: FILE: target/i386/tcg/sysemu/excp_helper.c:531:
+ /* Even if 4MB pages, we map only one 4KB page in the cache to
WARNING: Block comments use * on subsequent lines
#1134: FILE: target/i386/tcg/sysemu/excp_helper.c:532:
+ /* Even if 4MB pages, we map only one 4KB page in the cache to
+ avoid filling it too fast */
WARNING: Block comments use a trailing */ on a separate line
#1134: FILE: target/i386/tcg/sysemu/excp_helper.c:532:
+ avoid filling it too fast */
ERROR: braces {} are necessary for all arms of this statement
#1148: FILE: target/i386/tcg/sysemu/excp_helper.c:546:
+ if (is_user)
[...]
total: 1 errors, 11 warnings, 631 lines checked
Patch 9/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/17 Checking commit 5b0c9ae2cec4 (i386: move TCG btp_helper into sysemu/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#363:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#499: FILE: target/i386/tcg/sysemu/bpt_helper.c:132:
+ /* If nothing is changing except the global/local enable bits,
WARNING: Block comments use * on subsequent lines
#500: FILE: target/i386/tcg/sysemu/bpt_helper.c:133:
+ /* If nothing is changing except the global/local enable bits,
+ then we can make the change more efficient. */
WARNING: Block comments use a trailing */ on a separate line
#500: FILE: target/i386/tcg/sysemu/bpt_helper.c:133:
+ then we can make the change more efficient. */
WARNING: Block comments use a leading /* on a separate line
#502: FILE: target/i386/tcg/sysemu/bpt_helper.c:135:
+ /* Fold the global and local enable bits together into the
WARNING: Block comments use * on subsequent lines
#503: FILE: target/i386/tcg/sysemu/bpt_helper.c:136:
+ /* Fold the global and local enable bits together into the
+ global fields, then xor to show which registers have
WARNING: Block comments use a trailing */ on a separate line
#504: FILE: target/i386/tcg/sysemu/bpt_helper.c:137:
+ changed collective enable state. */
total: 0 errors, 7 warnings, 623 lines checked
Patch 10/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/17 Checking commit f31a404c49a9 (i386: split misc helper into user and
sysemu parts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#526:
new file mode 100644
ERROR: switch and case should be at the same indent
#819: FILE: target/i386/tcg/sysemu/misc_helper.c:289:
+ switch ((uint32_t)env->regs[R_ECX]) {
[...]
+ case MSR_IA32_UCODE_REV:
total: 1 errors, 1 warnings, 1009 lines checked
Patch 11/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
12/17 Checking commit 46a9e57851cf (i386: separate fpu_helper into user and
sysemu parts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#143:
new file mode 100644
total: 0 errors, 1 warnings, 219 lines checked
Patch 12/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/17 Checking commit bad90cd053db (i386: split svm_helper into sysemu and
stub-only user)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#33:
target/i386/tcg/{ => sysemu}/svm_helper.c | 62 +------------------------
total: 0 errors, 1 warnings, 169 lines checked
Patch 13/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/17 Checking commit 694927648c5b (i386: split seg_helper into user-only and
sysemu parts)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#320:
new file mode 100644
ERROR: do not use C99 // comments
#347: FILE: target/i386/tcg/seg_helper.h:23:
+//#define DEBUG_PCALL
WARNING: Block comments use a leading /* on a separate line
#620: FILE: target/i386/tcg/user/seg_helper.c:73:
+ /* Since we emulate only user space, we cannot do more than
WARNING: Block comments use * on subsequent lines
#621: FILE: target/i386/tcg/user/seg_helper.c:74:
+ /* Since we emulate only user space, we cannot do more than
+ exiting the emulation with the suitable exception and error
WARNING: Block comments use a trailing */ on a separate line
#622: FILE: target/i386/tcg/user/seg_helper.c:75:
+ code. So update EIP for INT 0x80 and EXCP_SYSCALL. */
WARNING: Block comments use a leading /* on a separate line
#633: FILE: target/i386/tcg/user/seg_helper.c:86:
+ /* if user mode only, we simulate a fake exception
WARNING: Block comments use * on subsequent lines
#634: FILE: target/i386/tcg/user/seg_helper.c:87:
+ /* if user mode only, we simulate a fake exception
+ which will be handled outside the cpu execution
WARNING: Block comments use a trailing */ on a separate line
#635: FILE: target/i386/tcg/user/seg_helper.c:88:
+ loop */
total: 1 errors, 7 warnings, 595 lines checked
Patch 14/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/17 Checking commit 02f72adf2325 (i386: split off sysemu part of cpu.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#51: FILE: target/i386/cpu-internal.h:30:
+ /* feature flags names are taken from "Intel Processor Identification and
WARNING: Block comments use a leading /* on a separate line
#134: FILE: target/i386/cpu-softmmu.c:37:
+/* Return a QDict containing keys for all properties that can be included
WARNING: Block comments use a leading /* on a separate line
#187: FILE: target/i386/cpu-softmmu.c:90:
+/* Convert CPU model data from X86CPU object to a property dictionary
WARNING: Block comments use a leading /* on a separate line
#201: FILE: target/i386/cpu-softmmu.c:104:
+/* Convert CPU model data from X86CPU object to a property dictionary
WARNING: Block comments use a leading /* on a separate line
#217: FILE: target/i386/cpu-softmmu.c:120:
+ /* "hotplugged" is the only property that is configurable
WARNING: Block comments use a leading /* on a separate line
#307: FILE: target/i386/cpu-softmmu.c:210:
+ /* As we don't return every single property, full expansion needs
total: 0 errors, 7 warnings, 895 lines checked
Patch 15/17 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/17 Checking commit f32fe53997ca (i386: gdbstub: only write CR0/CR2/CR3/EFER
for SOFTMMU)
17/17 Checking commit 10e4e7041872 (i386: move cpu_load_efer into sysemu-only
section of cpu.h)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20210224133428.14071-1-cfontana@suse.de/testing.checkpatch/?type=message">http://patchew.org/logs/20210224133428.14071-1-cfontana@suse.de/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
- [PATCH v22 11/17] i386: split misc helper into user and sysemu parts, (continued)
- [PATCH v22 11/17] i386: split misc helper into user and sysemu parts, Claudio Fontana, 2021/02/24
- [PATCH v22 17/17] i386: move cpu_load_efer into sysemu-only section of cpu.h, Claudio Fontana, 2021/02/24
- [PATCH v22 16/17] i386: gdbstub: only write CR0/CR2/CR3/EFER for SOFTMMU, Claudio Fontana, 2021/02/24
- [PATCH v22 15/17] i386: split off sysemu part of cpu.c, Claudio Fontana, 2021/02/24
- Re: [PATCH v22 00/17] i386 cleanup PART 2,
no-reply <=
- Re: [PATCH v22 00/17] i386 cleanup PART 2, Philippe Mathieu-Daudé, 2021/02/24