qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ui/cocoa: Do not rely on the first argument


From: Gerd Hoffmann
Subject: Re: [PATCH] ui/cocoa: Do not rely on the first argument
Date: Wed, 24 Feb 2021 12:55:48 +0100

On Tue, Feb 23, 2021 at 08:06:40PM +0900, Akihiko Odaki wrote:
> The first argument of the executable was used to get its path, but it is
> not reliable because the executer can specify any arbitrary string. Use the
> interfaces provided by QEMU and the platform to get those paths.
> 
> This change also changes the icon shown in the "about" window to QEMU's
> cute one.

Looks good to me, but I'd like to have an additional macos review for
this one.

thanks,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]