Re: softmmu vs sysemu [Was: Re: [RFC v1 06/38] target/arm: split off cpu-softmmu.c]

[Claudio Fontana]

On 2/24/21 10:20 AM, Paolo Bonzini wrote:
> On 24/02/21 01:06, Richard Henderson wrote:
>> On 2/23/21 3:43 PM, Philippe Mathieu-Daudé wrote:
>>> On 2/23/21 7:51 PM, Richard Henderson wrote:
>>>> I just want the file naming done correctly, while you're renaming.  That is
>>>> something you are actively changing in this patch set, so we should get it 
>>>> right.
>>>
>>> So what is the new directory structure?
>>>
>>> - user/
>>> - sysemu/{tcg,kvm,}/
>>>
>>> or
>>>
>>> - tcg/a-user.c
>>> - tcg/b-sysemu.c
>>> - kvm/kvm.c
>>
>> Personally I think this second one makes more sense, focused primarily on the
>> accelerator and secondarily on the kind of emulation.
> 
> I agree.

Agree here are well.

> 
> I don't care _too much_ about sysemu vs. softmmu.


I am neutral here as well.


>In any case if we 
> want to go with sysemu it can be done in steps:
> 
> - easy: rename files and directories

right. The ask in this series from Richard is to rename new files and 
directories from "softmmu" to "sysemu".

This gives us a resulting codebase where some directories are softmmu, some are 
sysemu, and the meson stuff is still softmmu.
To me this is a worse situation than where we started, but if I am the only one 
perceiving this I will just call the new directories and files "sysemu".


> 
> - medium: rename sourcesets in meson.build

right

> 
> - harder (or just larger): rename CONFIG_SOFTMMU

indeed. Currently (I think) CONFIG_SOFTMMU is the same as !CONFIG_USER_ONLY. 
But IIUC CONFIG_SOFTMMU would assume a new meaning after the change.

> 
> Paolo
>