[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] target/riscv: Reduce duplicated code in trans_rvh.c.i
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 1/2] target/riscv: Reduce duplicated code in trans_rvh.c.inc |
|
Date: |
Tue, 23 Feb 2021 16:24:35 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/22/21 10:49 AM, Alex Richardson wrote:
> I rencently merged CHERI QEMU up to 5.2, and we have to modify all
> functions that perform memory accesses. Factoring these almost-indentical
> functions into two shared helpers makes our changes a lot smaller and
> should also make this code easier to maintain.
> ---
> target/riscv/insn_trans/trans_rvh.c.inc | 199 ++++--------------------
> 1 file changed, 29 insertions(+), 170 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~