Re: [PATCH v2] meson.build: expose TCG cross compiler information in summary

[Philippe Mathieu-Daudé]

On Tue, Feb 16, 2021 at 11:49 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> On 16/02/21 11:25, Alex Bennée wrote:
> > Blink and you miss the cross TCG compiler stuff so lets display it
> > with the rest of the compiler information.
> >
> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >
> > ---
> > v2
> >    - use target_dirs/fs.exists() instead of find
>
> Acked-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Using $(wildcard) could be better than TARGET_DIRS in
> tests/Makefile.include, too, something like this:
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index d34254fb29..7203243b08 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -41,7 +41,7 @@ SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \
>   SPEED = quick
>
>   # Build up our target list from the filtered list of ninja targets
> -TARGETS=$(patsubst libqemu-%.fa, %, $(filter libqemu-%.fa,
> $(ninja-targets)))
> +TARGETS=$(patsubst tests/tcg/config-%.mak, %, $(wildcard
> tests/tcg/config-target.mak))
>
>   # Per guest TCG tests
>   BUILD_TCG_TARGET_RULES=$(patsubst %,build-tcg-tests-%, $(TARGETS))
> @@ -49,7 +49,7 @@ CLEAN_TCG_TARGET_RULES=$(patsubst %,clean-tcg-tests-%,
> $(TARGETS))
>   RUN_TCG_TARGET_RULES=$(patsubst %,run-tcg-tests-%, $(TARGETS))
>
>   # Probe for the Docker Builds needed for each build
> -$(foreach PROBE_TARGET,$(TARGET_DIRS),                                 \
> +$(foreach PROBE_TARGET,$(TARGETS),                             \
>         $(eval -include $(SRC_PATH)/tests/tcg/Makefile.prereqs))
>
>   $(BUILD_TCG_TARGET_RULES): build-tcg-tests-%: $(if
> $(CONFIG_PLUGIN),test-plugins)
>
>
> I'll test it and send it out.

Doesn't work with your diff:

make: *** No rule to make target 'run-tcg-tests-r5900o32el-linux-user'.  Stop.