Re: [RFC PATCH] target/mips/cp0_timer: Use new clock_ns_to_ticks()

[no-reply]

Patchew URL: 20210210234334.3750022-1-f4bug@amsat.org/">https://patchew.org/QEMU/20210210234334.3750022-1-f4bug@amsat.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210210234334.3750022-1-f4bug@amsat.org
Subject: [RFC PATCH] target/mips/cp0_timer: Use new clock_ns_to_ticks()

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
86c0e95 target/mips/cp0_timer: Use new clock_ns_to_ticks()

=== OUTPUT BEGIN ===
ERROR: space prohibited after that '-' (ctx:ExW)
#39: FILE: target/mips/cp0_timer.c:41:
+           - (uint32_t)(now_ticks / cpu->cp0_count_rate);
            ^

WARNING: line over 80 characters
#77: FILE: target/mips/cp0_timer.c:92:
+                                            
qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL));

WARNING: line over 80 characters
#82: FILE: target/mips/cp0_timer.c:94:
+        env->CP0_Count = count - (uint32_t)(cp0_count_ticks / 
cpu->cp0_count_rate);

total: 1 errors, 2 warnings, 104 lines checked

Commit 86c0e959ed23 (target/mips/cp0_timer: Use new clock_ns_to_ticks()) has 
style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210210234334.3750022-1-f4bug@amsat.org/testing.checkpatch/?type=message">http://patchew.org/logs/20210210234334.3750022-1-f4bug@amsat.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com