Re: [PATCH v2 15/42] esp: introduce esp_pdma_read() and esp_pdma_write() functions

[Philippe Mathieu-Daudé]

Hi Mark,

On 2/9/21 8:29 PM, Mark Cave-Ayland wrote:
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>  hw/scsi/esp.c | 28 ++++++++++++++++++++--------
>  1 file changed, 20 insertions(+), 8 deletions(-)
> 
> diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c
> index e7cf36f4b8..b0cba889a9 100644
> --- a/hw/scsi/esp.c
> +++ b/hw/scsi/esp.c
> @@ -151,6 +151,20 @@ static uint8_t *get_pdma_buf(ESPState *s)
>      return NULL;
>  }
>  

Can you add get_pdma_len() (similar to get_pdma_buf) and ...

> +static uint8_t esp_pdma_read(ESPState *s)
> +{
> +    uint8_t *buf = get_pdma_buf(s);
> +

       assert(s->pdma_cur < get_pdma_len(s));

> +    return buf[s->pdma_cur++];
> +}
> +
> +static void esp_pdma_write(ESPState *s, uint8_t val)
> +{
> +    uint8_t *buf = get_pdma_buf(s);
> +

Ditto.

> +    buf[s->pdma_cur++] = val;
> +}

Otherwise:

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>