qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

can surface_bits_per_pixel() for the console surface ever return anythin


From: Peter Maydell
Subject: can surface_bits_per_pixel() for the console surface ever return anything other than 32 ?
Date: Wed, 10 Feb 2021 18:02:20 +0000

Hi; I was doing a bit of cleanup of one or two of the older
display devices based on a note in BiteSizedTasks about removing
dead code that tries to support bit depths other than 32 for the
console display surface.

I notice that as well as handling surface_bits_per_pixel()
possibly returning 8, 15, 16, 24, these devices also seem to
check for the possibility it returns 0 (presumably meaning
"no surface" or "no surface yet" ?).

Is it still possible that surface_bits_per_pixel() could return 0
here, either transiently during system initialization or more
generally, eg for '-display none' ? Or is the 'case 0' code also
entirely dead ?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]